github/codeql-action
1
0
Fork 0
mirror of https://github.com/github/codeql-action.git synced 2025-12-24 08:10:06 +08:00
Code Issues Packages Projects Releases Wiki Activity

only retry on 5xx status codes

Browse Source
This commit is contained in:
Robert Brignull
2020-05-01 11:32:09 +01:00
parent e52e34ba17
commit 0c4fc16b49
2 changed files with 25 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
lib/upload-lib.js generated
View File

@@ -70,11 +70,18 @@ async function uploadPayload(payload) {
for (let attempt = 0; attempt <= backoffPeriods.length; attempt++) {
const res = await client.put(url, payload);
core.debug('response status: ' + res.message.statusCode);
if (res.message.statusCode === 202) {
const statusCode = res.message.statusCode;
if (statusCode === 202) {
core.info("Successfully uploaded results");
return;
}
const requestID = res.message.headers["x-github-request-id"];
// On any other status code that's not 5xx mark the upload as failed
if (!statusCode || statusCode < 500 || statusCode >= 600) {
core.setFailed('Upload failed (' + requestID + '): ' + await res.readBody());
return;
}
// On a 5xx status code we may retry the request
if (attempt < backoffPeriods.length) {
// Log the failure as a warning but don't mark the action as failed yet
core.warning('Upload attempt (' + (attempt + 1) + ' of ' + (backoffPeriods.length + 1) +
@@ -82,15 +89,14 @@ async function uploadPayload(payload) {
await res.readBody());
// Sleep for the backoff period
await new Promise(r => setTimeout(r, backoffPeriods[attempt] * 1000));
continue;
}
else if (res.message.statusCode === 500) {
// If the upload fails with 500 then we assume it is a temporary problem
else {
// If the upload fails with 5xx then we assume it is a temporary problem
// with turbo-scan and not an error that the user has caused or can fix.
// We avoid marking the job as failed to avoid breaking CI workflows.
core.error('Upload failed (' + requestID + '): ' + await res.readBody());
}
else {
core.setFailed('Upload failed (' + requestID + '): ' + await res.readBody());
return;
}
}
}