report status as failure if upload fails

lib/upload-lib.js

@@ -56,21 +56,24 @@ function combineSarifFiles(sarifFiles) {
 exports.combineSarifFiles = combineSarifFiles;
 // Uploads a single sarif file or a directory of sarif files
 // depending on what the path happens to refer to.
+// Returns true iff the upload occurred and succeeded
 async function upload(input) {
     if (fs.lstatSync(input).isDirectory()) {
         const sarifFiles = fs.readdirSync(input)
             .filter(f => f.endsWith(".sarif"))
             .map(f => path.resolve(input, f));
-        await uploadFiles(sarifFiles);
+        return await uploadFiles(sarifFiles);
     }
     else {
-        await uploadFiles([input]);
+        return await uploadFiles([input]);
     }
 }
 exports.upload = upload;
 // Uploads the given set of sarif files.
+// Returns true iff the upload occurred and succeeded
 async function uploadFiles(sarifFiles) {
     core.startGroup("Uploading results");
+    let succeeded = false;
     try {
         // Check if an upload has happened before. If so then abort.
         // This is intended to catch when the finish and upload-sarif actions
@@ -78,7 +81,7 @@ async function uploadFiles(sarifFiles) {
         const sentinelFile = await getSentinelFilePath();
         if (fs.existsSync(sentinelFile)) {
             core.info("Aborting as an upload has already happened from this job");
-            return;
+            return false;
         }
         const commitOid = util.getRequiredEnvParam('GITHUB_SHA');
         const workflowRunIDStr = util.getRequiredEnvParam('GITHUB_RUN_ID');
@@ -94,7 +97,7 @@ async function uploadFiles(sarifFiles) {
         const workflowRunID = parseInt(workflowRunIDStr, 10);
         if (Number.isNaN(workflowRunID)) {
             core.setFailed('GITHUB_RUN_ID must define a non NaN workflow run ID');
-            return;
+            return false;
         }
         let matrix = core.getInput('matrix');
         if (matrix === "null" || matrix === "") {
@@ -131,6 +134,7 @@ async function uploadFiles(sarifFiles) {
         }
         else {
             core.info("Successfully uploaded results");
+            succeeded = true;
         }
         // Mark that we have made an upload
         fs.writeFileSync(sentinelFile, '');
@@ -139,4 +143,5 @@ async function uploadFiles(sarifFiles) {
         core.setFailed(error.message);
     }
     core.endGroup();
+    return succeeded;
 }