Use extraction via build mode in autobuild Action when available

src/analyze-action.ts

@@ -20,7 +20,7 @@ import { getCodeQL } from "./codeql";
 import { Config, getConfig } from "./config-utils";
 import { uploadDatabases } from "./database-upload";
 import { EnvVar } from "./environment";
-import { Features } from "./feature-flags";
+import { FeatureEnablement, Features } from "./feature-flags";
 import { Language } from "./languages";
 import { getActionsLogger, Logger } from "./logging";
 import { parseRepositoryNwo } from "./repository";
@@ -140,7 +140,11 @@ function doesGoExtractionOutputExist(config: Config): boolean {
  * - We approximate whether manual build steps are present by looking at
  * whether any extraction output already exists for Go.
  */
-async function runAutobuildIfLegacyGoWorkflow(config: Config, logger: Logger) {
+async function runAutobuildIfLegacyGoWorkflow(
+  config: Config,
+  features: FeatureEnablement,
+  logger: Logger,
+) {
   if (!config.languages.includes(Language.go)) {
     return;
   }
@@ -177,7 +181,7 @@ async function runAutobuildIfLegacyGoWorkflow(config: Config, logger: Logger) {
   logger.debug(
     "Running Go autobuild because extraction output (TRAP files) for Go code has not been found.",
   );
-  await runAutobuild(Language.go, config, logger);
+  await runAutobuild(Language.go, config, features, logger);
 }
 
 async function run() {
@@ -247,7 +251,7 @@ async function run() {
     );
 
     await warnIfGoInstalledAfterInit(config, logger);
-    await runAutobuildIfLegacyGoWorkflow(config, logger);
+    await runAutobuildIfLegacyGoWorkflow(config, features, logger);
 
     dbCreationTimings = await runFinalize(
       outputDir,

src/analyze.ts

@@ -158,26 +158,7 @@ export async function runExtraction(
         ) {
           await setupCppAutobuild(codeql, logger);
         }
-        try {
-          await codeql.extractUsingBuildMode(config, language);
-        } catch (e) {
-          if (config.buildMode === BuildMode.Autobuild) {
-            const prefix =
-              "We were unable to automatically build your code. " +
-              "Please change the build mode for this language to manual and specify build steps " +
-              "for your project. For more information, see " +
-              "https://docs.github.com/en/code-security/code-scanning/troubleshooting-code-scanning/automatic-build-failed.";
-            const ErrorConstructor =
-              e instanceof util.ConfigurationError
-                ? util.ConfigurationError
-                : Error;
-            throw new ErrorConstructor(
-              `${prefix} ${util.wrapError(e).message}`,
-            );
-          } else {
-            throw e;
-          }
-        }
+        await codeql.extractUsingBuildMode(config, language);
       } else {
         await codeql.extractScannedLanguage(config, language);
       }

src/autobuild-action.ts

@@ -10,8 +10,10 @@ import { determineAutobuildLanguages, runAutobuild } from "./autobuild";
 import { getCodeQL } from "./codeql";
 import { Config, getConfig } from "./config-utils";
 import { EnvVar } from "./environment";
+import { Features } from "./feature-flags";
 import { Language } from "./languages";
 import { Logger, getActionsLogger } from "./logging";
+import { parseRepositoryNwo } from "./repository";
 import {
   StatusReportBase,
   getActionsStatus,
@@ -23,6 +25,7 @@ import {
   checkActionVersion,
   checkDiskUsage,
   checkGitHubVersionInRange,
+  getRequiredEnvParam,
   initializeEnvironment,
   wrapError,
 } from "./util";
@@ -88,6 +91,17 @@ async function run() {
     checkGitHubVersionInRange(gitHubVersion, logger);
     checkActionVersion(getActionVersion(), gitHubVersion);
 
+    const repositoryNwo = parseRepositoryNwo(
+      getRequiredEnvParam("GITHUB_REPOSITORY"),
+    );
+
+    const features = new Features(
+      gitHubVersion,
+      repositoryNwo,
+      getTemporaryDirectory(),
+      logger,
+    );
+
     config = await getConfig(getTemporaryDirectory(), logger);
     if (config === undefined) {
       throw new Error(
@@ -108,7 +122,7 @@ async function run() {
       }
       for (const language of languages) {
         currentLanguage = language;
-        await runAutobuild(language, config, logger);
+        await runAutobuild(language, config, features, logger);
       }
     }
   } catch (unwrappedError) {

src/autobuild.ts

@@ -5,7 +5,12 @@ import { getGitHubVersion } from "./api-client";
 import { CodeQL, getCodeQL } from "./codeql";
 import * as configUtils from "./config-utils";
 import { EnvVar } from "./environment";
-import { Feature, featureConfig, Features } from "./feature-flags";
+import {
+  Feature,
+  featureConfig,
+  FeatureEnablement,
+  Features,
+} from "./feature-flags";
 import { isTracedLanguage, Language } from "./languages";
 import { Logger } from "./logging";
 import { parseRepositoryNwo } from "./repository";
@@ -154,6 +159,7 @@ export async function setupCppAutobuild(codeql: CodeQL, logger: Logger) {
 export async function runAutobuild(
   language: Language,
   config: configUtils.Config,
+  features: FeatureEnablement,
   logger: Logger,
 ) {
   logger.startGroup(`Attempting to automatically build ${language} code`);
@@ -161,7 +167,14 @@ export async function runAutobuild(
   if (language === Language.cpp) {
     await setupCppAutobuild(codeQL, logger);
   }
-  await codeQL.runAutobuild(language, config.debugMode);
+  if (
+    config.buildMode &&
+    (await features.getValue(Feature.AutobuildDirectTracingEnabled, codeQL))
+  ) {
+    await codeQL.extractUsingBuildMode(config, language);
+  } else {
+    await codeQL.runAutobuild(language, config.debugMode);
+  }
   if (language === Language.go) {
     core.exportVariable(EnvVar.DID_AUTOBUILD_GOLANG, "true");
   }

src/codeql.ts

@@ -30,7 +30,7 @@ import * as setupCodeql from "./setup-codeql";
 import { ToolsFeature, isSupportedToolsFeature } from "./tools-features";
 import { shouldEnableIndirectTracing } from "./tracer-config";
 import * as util from "./util";
-import { wrapError } from "./util";
+import { BuildMode, wrapError } from "./util";
 
 type Options = Array<string | number | boolean>;
 
@@ -681,15 +681,32 @@ export async function getCodeQLForCmd(
       ]);
     },
     async extractUsingBuildMode(config: Config, language: Language) {
-      await runTool(cmd, [
-        "database",
-        "trace-command",
-        "--use-build-mode",
-        ...(await getTrapCachingExtractorConfigArgsForLang(config, language)),
-        ...getExtractionVerbosityArguments(config.debugMode),
-        ...getExtraOptionsFromEnv(["database", "trace-command"]),
-        util.getCodeQLDatabasePath(config, language),
-      ]);
+      try {
+        await runTool(cmd, [
+          "database",
+          "trace-command",
+          "--use-build-mode",
+          ...(await getTrapCachingExtractorConfigArgsForLang(config, language)),
+          ...getExtractionVerbosityArguments(config.debugMode),
+          ...getExtraOptionsFromEnv(["database", "trace-command"]),
+          util.getCodeQLDatabasePath(config, language),
+        ]);
+      } catch (e) {
+        if (config.buildMode === BuildMode.Autobuild) {
+          const prefix =
+            "We were unable to automatically build your code. " +
+            "Please change the build mode for this language to manual and specify build steps " +
+            "for your project. For more information, see " +
+            "https://docs.github.com/en/code-security/code-scanning/troubleshooting-code-scanning/automatic-build-failed.";
+          const ErrorConstructor =
+            e instanceof util.ConfigurationError
+              ? util.ConfigurationError
+              : Error;
+          throw new ErrorConstructor(`${prefix} ${util.wrapError(e).message}`);
+        } else {
+          throw e;
+        }
+      }
     },
     async finalizeDatabase(
       databasePath: string,