github/codeql-action
1
0
Fork 0
mirror of https://github.com/github/codeql-action.git synced 2025-12-22 15:20:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

Represent feature flags using an enum

Browse Source 
Replaces the previous string literal type
This commit is contained in:
Henry Mercer
2021-12-16 13:14:32 +00:00
parent 5e87034b3b
commit 6d62c245ec
12 changed files with 88 additions and 108 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/database-upload.test.ts
View File

@@ -10,7 +10,7 @@ import * as apiClient from "./api-client";
import { setCodeQL } from "./codeql";
import { Config } from "./config-utils";
import { uploadDatabases } from "./database-upload";
import { createFeatureFlags, FeatureFlags } from "./feature-flags";
import { createFeatureFlags, FeatureFlag, FeatureFlags } from "./feature-flags";
import { Language } from "./languages";
import { RepositoryNwo } from "./repository";
import {
@@ -34,8 +34,8 @@ test.beforeEach(() => {
});
const uploadToUploadsDomainFlags = createFeatureFlags([
"database_uploads_enabled",
"uploads_domain_enabled",
FeatureFlag.DatabaseUploadsEnabled,
FeatureFlag.UploadsDomainEnabled,
]);
const testRepoName: RepositoryNwo = { owner: "github", repo: "example" };
@@ -70,7 +70,7 @@ async function mockHttpRequests(
const requestSpy = sinon.stub(client, "request");
const url = (await featureFlags.getUploadsDomainEnabled())
const url = (await featureFlags.getValue(FeatureFlag.UploadsDomainEnabled))
? "POST https://uploads.github.com/repos/:owner/:repo/code-scanning/codeql/databases/:language?name=:name"
: "PUT /repos/:owner/:repo/code-scanning/codeql/databases/:language";
const databaseUploadSpy = requestSpy.withArgs(url);
@@ -218,7 +218,7 @@ test("Abort database upload if feature flag is disabled", async (t) => {
await uploadDatabases(
testRepoName,
getTestConfig(tmpDir),
createFeatureFlags(["uploads_domain_enabled"]),
createFeatureFlags([FeatureFlag.UploadsDomainEnabled]),
testApiDetails,
getRecordingLogger(loggedMessages)
);
@@ -242,7 +242,9 @@ test("Don't crash if uploading a database fails", async (t) => {
.returns("true");
sinon.stub(actionsUtil, "isAnalyzingDefaultBranch").resolves(true);
const featureFlags = createFeatureFlags(["database_uploads_enabled"]);
const featureFlags = createFeatureFlags([
FeatureFlag.DatabaseUploadsEnabled,
]);
await mockHttpRequests(featureFlags, 500);
@@ -261,8 +263,6 @@ test("Don't crash if uploading a database fails", async (t) => {
getRecordingLogger(loggedMessages)
);
console.log(loggedMessages);
t.assert(
loggedMessages.find(
(v) =>