Add workload_run_attempt to analysis upload (#1658)

* Refactor status report upload logic

Previously we had duplicated the logic to check `GITHUB_RUN_ID`. We now call the `getWorkflowRunID()` method for the status report upload method, and move the logic for the run attempt to `getWorkflowRunAttempt()`

* Add `workflow_run_attempt` to analysis payload

* Stop allowing `undefined` run IDs and attempts

Because we already throw an error if the ID or attempt aren't numbers, we don't have to allow `undefined` values into the payload.

src/upload-lib.ts

@@ -173,6 +173,7 @@ export async function uploadFromActions(
     category,
     util.getRequiredEnvParam("GITHUB_WORKFLOW"),
     workflow.getWorkflowRunID(),
+    workflow.getWorkflowRunAttempt(),
     checkoutPath,
     actionsUtil.getRequiredInput("matrix"),
     logger
@@ -255,7 +256,8 @@ export function buildPayload(
   analysisKey: string | undefined,
   analysisName: string | undefined,
   zippedSarif: string,
-  workflowRunID: number | undefined,
+  workflowRunID: number,
+  workflowRunAttempt: number,
   checkoutURI: string,
   environment: string | undefined,
   toolNames: string[],
@@ -268,6 +270,7 @@ export function buildPayload(
     analysis_name: analysisName,
     sarif: zippedSarif,
     workflow_run_id: workflowRunID,
+    workflow_run_attempt: workflowRunAttempt,
     checkout_uri: checkoutURI,
     environment,
     started_at: process.env[CODEQL_WORKFLOW_STARTED_AT],
@@ -312,7 +315,8 @@ async function uploadFiles(
   analysisKey: string,
   category: string | undefined,
   analysisName: string | undefined,
-  workflowRunID: number | undefined,
+  workflowRunID: number,
+  workflowRunAttempt: number,
   sourceRoot: string,
   environment: string | undefined,
   logger: Logger
@@ -352,6 +356,7 @@ async function uploadFiles(
     analysisName,
     zippedSarif,
     workflowRunID,
+    workflowRunAttempt,
     checkoutURI,
     environment,
     toolNames,