From e33b0ab3ac30b90dff43239fd6ba035a77c2fed2 Mon Sep 17 00:00:00 2001 From: "Michael B. Gale" Date: Thu, 18 Sep 2025 14:52:50 +0100 Subject: [PATCH] Update `upload-quality-sarif` check to only use `code-quality` --- .github/workflows/__upload-quality-sarif.yml | 8 +++++--- pr-checks/checks/upload-quality-sarif.yml | 7 +++++-- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/.github/workflows/__upload-quality-sarif.yml b/.github/workflows/__upload-quality-sarif.yml index ca3ffb988..41611260a 100644 --- a/.github/workflows/__upload-quality-sarif.yml +++ b/.github/workflows/__upload-quality-sarif.yml @@ -74,9 +74,7 @@ jobs: with: tools: ${{ steps.prepare-test.outputs.tools-url }} languages: cpp,csharp,java,javascript,python - config-file: ${{ github.repository }}/tests/multi-language-repo/.github/codeql/custom-queries.yml@${{ - github.sha }} - analysis-kinds: code-scanning,code-quality + analysis-kinds: code-quality - name: Build code run: ./build.sh # Generate some SARIF we can upload with the upload-sarif step @@ -86,8 +84,12 @@ jobs: sha: 5e235361806c361d4d3f8859e3c897658025a9a2 upload: never - uses: ./../action/upload-sarif + id: upload-sarif with: ref: refs/heads/main sha: 5e235361806c361d4d3f8859e3c897658025a9a2 + - name: Check output from `upload-sarif` step + if: fromJSON(steps.upload-sarif.sarif-ids)[0].analysis != 'code-quality' + run: exit 1 env: CODEQL_ACTION_TEST_MODE: true diff --git a/pr-checks/checks/upload-quality-sarif.yml b/pr-checks/checks/upload-quality-sarif.yml index 9538505af..4c6ae27f3 100644 --- a/pr-checks/checks/upload-quality-sarif.yml +++ b/pr-checks/checks/upload-quality-sarif.yml @@ -7,8 +7,7 @@ steps: with: tools: ${{ steps.prepare-test.outputs.tools-url }} languages: cpp,csharp,java,javascript,python - config-file: ${{ github.repository }}/tests/multi-language-repo/.github/codeql/custom-queries.yml@${{ github.sha }} - analysis-kinds: code-scanning,code-quality + analysis-kinds: code-quality - name: Build code run: ./build.sh # Generate some SARIF we can upload with the upload-sarif step @@ -18,6 +17,10 @@ steps: sha: '5e235361806c361d4d3f8859e3c897658025a9a2' upload: never - uses: ./../action/upload-sarif + id: upload-sarif with: ref: 'refs/heads/main' sha: '5e235361806c361d4d3f8859e3c897658025a9a2' + - name: "Check output from `upload-sarif` step" + if: fromJSON(steps.upload-sarif.sarif-ids)[0].analysis != 'code-quality' + run: exit 1