Commit Graph

179 Commits

Author SHA1 Message Date
Henry Mercer
a0041ad76c Keep analysis_name field consistent 2024-07-08 10:30:24 +01:00
Henry Mercer
9679491cab Avoid reloading features when uploading SARIF 2024-07-01 14:34:11 +02:00
Henry Mercer
6c2a71ced3 Remove redundant layer from upload files functions 2024-07-01 14:31:44 +02:00
github-actions[bot]
9cf3243b0b Rebuild 2024-06-25 09:21:42 +00:00
Henry Mercer
1ea11ca775 Enable no-unsafe-return rule 2024-06-13 19:52:39 +01:00
Henry Mercer
e7d04fdb41 Enable unsafe call rule 2024-06-13 19:38:06 +01:00
Koen Vlaswinkel
931fabe1ef Remove feature flag for combine SARIF files deprecation warning 2024-05-14 11:00:12 +02:00
Henry Mercer
b1c3187939 Add more invalid SARIF processing errors 2024-05-08 13:36:10 +01:00
Marco Gario
4673d41da1 Build js files 2024-05-06 18:44:55 +00:00
Koen Vlaswinkel
b20bf5914d Remove CLI SARIF merge feature flag 2024-05-03 15:14:12 +02:00
Koen Vlaswinkel
5d274be858 Update CodeQL deprecation message 2024-05-02 14:02:42 +02:00
Koen Vlaswinkel
3a471a06fa Update comment 2024-05-02 14:01:44 +02:00
Koen Vlaswinkel
725ed4139d Add tests for shouldShowCombineSarifFilesDeprecationWarning 2024-05-02 10:20:11 +02:00
Koen Vlaswinkel
1de9b371a1 Clarify name of function 2024-05-02 10:01:11 +02:00
Koen Vlaswinkel
757fcd3d21 Remove unnecessary optional chaining 2024-05-02 10:00:29 +02:00
Koen Vlaswinkel
40f70f96b1 Extract more information message 2024-05-02 09:59:52 +02:00
Koen Vlaswinkel
b3225af51b Mention GHES 3.18 as removal version on GHES 2024-04-26 14:38:20 +02:00
Koen Vlaswinkel
905f9b0083 Only show deprecation warning on GHES 3.14+ 2024-04-26 14:38:06 +02:00
Koen Vlaswinkel
80394dcc32 Hide deprecation warning if feature flag is not set 2024-04-26 14:37:27 +02:00
Koen Vlaswinkel
a5e49d1544 Extract check for combine SARIF files deprecation warning 2024-04-26 14:36:54 +02:00
Koen Vlaswinkel
24acd7711e Set correct changelog URL 2024-04-26 14:23:51 +02:00
Koen Vlaswinkel
8b0dfa84c7 Add deprecation warning for merging SARIF files with non-unique categories 2024-04-26 14:22:30 +02:00
Koen Vlaswinkel
5d73b1bd71 Remove incorrect log message 2024-04-17 10:20:46 +02:00
Henry Mercer
e006461bad Mark some upload-sarif errors as always configuration errors 2024-04-15 15:52:19 +01:00
Henry Mercer
fa75c144b4 Capture rate limit and ref not existing config errors 2024-04-12 18:25:10 +01:00
nickfyson
c037115ddf clarify logging in response to pr review comments 2024-04-03 21:19:06 +01:00
Nick Fyson
2cc8bbd0e0 Apply suggestions from code review
Co-authored-by: Henry Mercer <henrymercer@github.com>
2024-04-03 20:42:48 +01:00
nickfyson
6514cbb626 improve logging coverage when uploaing sarif files 2024-04-03 15:45:28 +01:00
Koen Vlaswinkel
016720d81f Refactor areAllRunsProducedByCodeQL to use Array.every 2024-03-26 11:09:44 +01:00
Koen Vlaswinkel
3c4b8bc120 Change log levels 2024-03-25 10:15:37 +01:00
Koen Vlaswinkel
a0a63a2dd4 Do not try merging a single SARIF file 2024-03-25 10:15:16 +01:00
Koen Vlaswinkel
3bd271cec3 Introduce areAllRunsProducedByCodeQL function 2024-03-25 10:14:59 +01:00
Koen Vlaswinkel
6ac57535de Use options object instead of boolean for mergeResults 2024-03-25 10:13:15 +01:00
Koen Vlaswinkel
e20c273295 Use supportsFeature check for merging SARIF files 2024-03-22 14:15:42 +01:00
Koen Vlaswinkel
7e30c622b0 Use subdirectory for combined SARIF file 2024-03-22 14:15:16 +01:00
Koen Vlaswinkel
ccc609bf1a Use github merge-results command when feature flag is enabled 2024-03-22 14:15:00 +01:00
Henry Mercer
c84e4c8e7b Mark some more processing errors as invalid SARIF upload requests 2024-03-20 20:55:54 +00:00
Henry Mercer
888ab31e3e Mark third-party SARIF limits errors as configuration errors 2024-02-28 19:41:43 +00:00
Henry Mercer
bd56a05133 Rename InvalidRequestError to InvalidSarifUploadError
Nitty: make it a little clearer when this shows up in the logs what type of request we mean
2024-02-28 19:25:30 +00:00
Angela P Wen
62712e9ff9 Throw InvalidRequestError if JSON parsing fails 2024-02-28 16:02:37 +00:00
Angela P Wen
52f2347108 Consider SyntaxErrors configuration errors 2024-02-28 15:23:11 +00:00
Angela P Wen
1a6bac42d0 Rename considerInvalidRequestConfigError to isThirdPartyUpload
This describes what we are trying to do more accurately.
2024-02-28 15:22:39 +00:00
Josh Soref
5a6da1d85d Treat status reports as non-critical
Change `sendStatusReport` to `void`
2024-02-12 13:56:10 -05:00
Angela P Wen
1515e2bb20 Refactor configuration errors (#2105)
Refactor the existing classes of configuration errors into their own file; consolidate the place we check for configuration errors into `codeql.ts`, where the actual command invocations happen.

Also, rename the `UserError` type to `ConfigurationError` to standardize on a single term.
2024-02-08 17:20:03 +00:00
Henry Mercer
fdea2a523d Remove result pruning for CodeQL 2.11.2 2023-11-27 12:58:49 +00:00
Henry Mercer
a7c12a5225 Address PR comments 2023-09-07 20:44:15 +01:00
Henry Mercer
583a1019cc Mark invalid SARIF errors as user errors in the upload-sarif Action 2023-09-06 18:14:30 +01:00
Henry Mercer
bcfe48982e Improve function name 2023-07-28 18:51:43 +01:00
Henry Mercer
79690d4663 Make submitting advanced analysis when default setup on a user error 2023-07-28 18:21:38 +01:00
Henry Mercer
2637069a45 Resolve dependency cycles between actions-util and workflow 2023-07-19 17:21:33 +01:00