Cornelius Riemenschneider
ceec52c4bc
Address review.
2022-07-21 17:03:57 +00:00
Cornelius Riemenschneider
a32664975f
autobuild-action: Run autobuilders with $CODEQL_RUNNER set.
...
Without this, the tracer will not be injected on MacOS, as we need the
runner to circumvent SIP.
Also add a test that tests the autobuild-action to exercise this code path.
2022-07-21 15:51:54 +00:00
Henry Mercer
8171514c02
Merge pull request #1146 from github/dependabot/npm_and_yarn/runner/terser-5.14.2
...
Bump terser from 5.7.1 to 5.14.2 in /runner
2022-07-20 10:51:28 +01:00
dependabot[bot]
6fa0b7cb22
Bump terser from 5.7.1 to 5.14.2 in /runner
...
Bumps [terser](https://github.com/terser/terser ) from 5.7.1 to 5.14.2.
- [Release notes](https://github.com/terser/terser/releases )
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/terser/terser/commits )
---
updated-dependencies:
- dependency-name: terser
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-20 01:49:59 +00:00
Alexander Eyers-Taylor
b8bd06e075
Merge pull request #1143 from github/alexet/codeql-2.10.1-update
...
Update bundle to 2.10.1
2022-07-19 15:38:55 +01:00
Alexander Eyers-Taylor
aa231930c1
Merge branch 'main' into alexet/codeql-2.10.1-update
2022-07-19 14:41:49 +01:00
Cornelius Riemenschneider
ba95eeb60e
Merge pull request #1145 from github/criemen/fix-ff-crash
...
Don't crash if we are unable to get a response from the feature-flag endpoint.
2022-07-18 14:04:23 +02:00
Cornelius Riemenschneider
c059f95c05
Fix lint errors.
2022-07-18 11:26:03 +00:00
Cornelius Riemenschneider
75afbf4a30
Address review, add test.
2022-07-18 10:37:04 +00:00
Cornelius Riemenschneider
01fa64cb90
Don't crash if we are unable to get a response from the feature-flag endpoint.
2022-07-18 10:14:40 +00:00
Alexander Eyers-Taylor
28ccb035bb
Changelog: Pick the correct PR after opening
...
Co-authored-by: Henry Mercer <henrymercer@github.com >
2022-07-14 16:20:45 +01:00
alexet
11111290fc
Update bundle to 2.10.1
2022-07-14 15:37:28 +01:00
Edoardo Pirovano
d8c9c723a5
Merge pull request #1141 from github/mergeback/v2.1.16-to-main-3e7e3b32
...
Mergeback v2.1.16 refs/heads/releases/v2 into main
codeql-bundle-20220714
2022-07-13 15:16:52 +01:00
github-actions[bot]
8d24c9e4c1
Update checked-in dependencies
2022-07-13 13:25:21 +00:00
github-actions[bot]
c8971b8e0a
Update changelog and version after v2.1.16
2022-07-13 11:26:38 +00:00
Cornelius Riemenschneider
3e7e3b32d0
Merge pull request #1140 from github/update-v2.1.16-548f07e3
...
Merge main into releases/v2
v2.1.16
2022-07-13 12:55:19 +02:00
github-actions[bot]
330d552535
Update changelog for v2.1.16
2022-07-13 10:05:10 +00:00
Andrew Eisenberg
548f07e307
Merge pull request #1139 from github/aeisenberg/concat-not-push
...
Use concat instead of push around `listFolders`
2022-07-13 02:39:34 -07:00
Henry Mercer
a844fefc86
Merge branch 'main' into aeisenberg/concat-not-push
2022-07-13 10:09:16 +01:00
Andrew Eisenberg
7ce9ef9137
Use concat instead of push around listFolders
...
This avoids stack overflows when using the spread operator on
directories that have many, many children.
2022-07-12 13:23:01 -07:00
Henry Mercer
d750c6d79d
Merge pull request #1138 from github/henrymercer/drop-token-check
...
Update required checks: Allow authenticating via the GitHub CLI
2022-07-12 19:57:01 +01:00
Henry Mercer
4cb248b0ec
Merge branch 'main' into henrymercer/drop-token-check
2022-07-12 18:21:09 +01:00
Henry Mercer
1e7f770864
Merge pull request #1132 from github/henrymercer/one-click-debug
...
Enable one-click debugging via the "Enable debug logging" option when re-running Actions jobs
2022-07-12 18:10:16 +01:00
Henry Mercer
816b3e91bc
Update failure message
...
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
2022-07-12 17:52:15 +01:00
Henry Mercer
fbbd1dcd52
Fix extra double quote
...
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
2022-07-12 17:44:51 +01:00
Henry Mercer
0a5dad3c83
Allow authenticating via the GitHub CLI
...
We no longer run this script within Actions for security reasons, and
when running locally we can authenticate with the GitHub CLI instead
of a PAT.
2022-07-12 17:33:24 +01:00
Henry Mercer
d61e3fdf02
Fix shellcheck errors
...
Avoid trying to evaluate `github/codeql-action`.
2022-07-12 17:31:31 +01:00
Henry Mercer
dca60ba711
Merge remote-tracking branch 'origin/main' into henrymercer/one-click-debug
2022-07-12 16:54:30 +01:00
Cornelius Riemenschneider
e1ec69721f
Merge pull request #1137 from github/criemen/fix-end-tracing
...
Unset tracing variables after finalizing databases.
2022-07-12 17:49:59 +02:00
Henry Mercer
b45ac1f8f8
Cleanup: Use optional chaining in a couple of places
2022-07-12 16:30:21 +01:00
Henry Mercer
b316baae94
Merge remote-tracking branch 'origin/main' into henrymercer/one-click-debug
2022-07-12 16:22:05 +01:00
Henry Mercer
e655fb331c
Use core.isDebug() instead of accessing env var
2022-07-12 16:19:13 +01:00
Henry Mercer
b3801753d4
Merge pull request #1133 from github/henrymercer/log-diagnostics-when-debug-enabled
...
Print diagnostic messages when debugging mode is enabled
2022-07-12 15:49:16 +01:00
Cornelius Riemenschneider
3dcdbc9add
Unset tracing variables after finalizing databases.
...
The tracer is very good at preserving itself, so unsetting the tracing-specific
variables from within a process will not end tracing for children of
that process.
The way the actions process model works means that we're running inside
a process for the entire build step that was launched with the tracer
variables set, so we'll have the tracer injected into the entire build
step and its children.
If we unset the variables in end-tracing, we will get into an intermediate
state: Not all variables in there are preserved by the tracer,
but the tracer is still active.
Usually, that wouldn't be a problem, but the autobuilders called from
the finalize step will suddenly run under a half-configured tracer.
Particularly, this half-configured tracer is unable to execute the dotnet
CLI without hangs, as the environment variable that prevents hangs for
dotnet on MacOS has been unset, but the tracer is still active.
This is an issue for the the go autobuilder, that invokes
user-provided build scripts in the hope of installing dependencies.
If that build script then invokes dotnet, it will hang.
This is only of concern for the Lua tracer that now implements proper
multi-language tracing: Previously, when encountering the go autobuilder,
the tracer disabled itself entirely, thus side-stepping any hangs.
In the new, multi-language tracing world, the tracer will stay active
as long as there is at least one other language that's been set up
for tracing.
Thus, we also get hangs when invoking the dotnet CLI through the go
autobuilder.
2022-07-12 11:33:44 +00:00
Henry Mercer
688508d8cb
Merge pull request #1099 from github/henrymercer/run-unit-tests-on-windows
...
Run unit tests on Windows too
2022-07-12 11:06:41 +01:00
Henry Mercer
fc926423a5
Merge remote-tracking branch 'origin/main' into henrymercer/run-unit-tests-on-windows
2022-07-11 17:57:19 +01:00
Henry Mercer
ea8fb214de
Merge pull request #1104 from github/henrymercer/remove-toolcache-decorator
...
Remove toolcache decorator
2022-07-11 17:54:54 +01:00
Henry Mercer
3a5fa35535
Add changelog note
2022-07-01 19:14:38 +01:00
Henry Mercer
7e94a6cbca
Print diagnostic messages when debug logging enabled
...
This commit prints diagnostic messages to the Actions log when debug
logging is enabled by passing `debug: true` to `codeql-action/init` or
enabling Actions step debug logging.
2022-07-01 18:56:12 +01:00
Henry Mercer
b7da732b32
Add changelog note
2022-07-01 18:47:41 +01:00
Henry Mercer
0c729c81f2
Mention that debug mode is automatically enabled when step debugging on
2022-07-01 17:59:10 +01:00
Henry Mercer
53850d88bb
Enable one-click debugging via the "Enable debug logging" rerun option
2022-07-01 17:56:57 +01:00
Henry Mercer
b1742f8919
Add instructions to remove deleted JS / source map files in PR check
2022-06-30 09:16:11 +01:00
Henry Mercer
c736697abf
Remove toolcache decorator
...
This decorator enabled us to use the functionality of the Actions
toolcache within the runner too.
Now that we've deleted the runner we no longer need it.
2022-06-30 09:16:10 +01:00
Arthur Baars
ca8a203b51
Merge pull request #1126 from github/aibaars/python-setup-no-pycache
...
Python-Setup: run auto_install_packages.py with -B flag
2022-06-30 10:08:46 +02:00
Arthur Baars
53bc5e6c78
Merge remote-tracking branch 'origin/main' into aibaars/python-setup-no-pycache
2022-06-30 09:10:41 +02:00
Henry Mercer
130a51dbc6
Handle Windows absolute paths in resolveUriToFile
2022-06-29 18:59:33 +01:00
Henry Mercer
c2fd5d10f6
Don't make temporary directories symlinks
...
`toolcache.extractTar` currently falls over when `ACTIONS_TEMP` contains
a symlink, and the runner no longer exists, so it's unlikely our
customers would be running with temporary directories that contain
symlinks.
2022-06-29 18:59:33 +01:00
Henry Mercer
30681e79db
Separate paths with / in resolveUriToFile
2022-06-29 18:59:32 +01:00
Henry Mercer
c15604920a
Workaround PATH casing issues on Windows
2022-06-29 18:59:32 +01:00