Andrew Eisenberg
9ba4d500aa
Merge pull request #1221 from github/aeisenberg/ghes-pack-download
...
Add support for downloading packs from GHES
2022-09-08 10:02:41 -07:00
Andrew Eisenberg
6085805a3a
Append / to end of registries url
...
Avoids a bug in 2.10.4. Also, add some better handling for invalid
registries blocks.
2022-09-08 08:00:24 -07:00
Andrew Eisenberg
59744464eb
Fix unit tests
2022-09-07 16:10:34 -07:00
Andrew Eisenberg
4fa3e8b483
Gate the new registries input behind version constraints
2022-09-07 14:38:44 -07:00
David Verdeguer
063e083705
Fix linting
2022-09-07 22:45:34 +02:00
David Verdeguer
a03f3bd585
Build js
2022-09-07 09:45:19 +02:00
Andrew Eisenberg
376fea671d
Clarify description of registries input
2022-09-06 14:06:30 -07:00
Andrew Eisenberg
bf97a6da5b
Apply suggestions from code review
2022-09-06 10:41:32 -07:00
Andrew Eisenberg
7e086b240c
Merge remote-tracking branch 'upstream/main' into aeisenberg/ghes-pack-download
2022-09-06 10:22:00 -07:00
Edoardo Pirovano
299b77421b
TRAP Caching: Be tolerant to not finding the extractor
2022-09-05 10:38:21 +01:00
Andrew Eisenberg
abdf26c28f
Convert from json to yaml for registries input
2022-09-02 15:03:51 -07:00
Henry Mercer
fc2f344141
Reuse getApiDetails code
2022-09-02 19:59:18 +01:00
Andrew Eisenberg
b0443622cd
Merge branch 'main' into aeisenberg/ghes-pack-download
2022-09-02 11:32:07 -07:00
Henry Mercer
4b5dea8eed
Address review comments
2022-09-02 17:54:53 +01:00
Henry Mercer
62b4f237aa
Merge remote-tracking branch 'origin/main' into henrymercer/start-go-tracing-in-init
2022-09-02 17:39:17 +01:00
Henry Mercer
21530f507f
Merge pull request #1219 from github/angelapwen/autobuild-in-analyze
...
Autobuild Go in `analyze` if not already built
2022-09-02 17:36:54 +01:00
Andrew Eisenberg
e9b47b1898
Change to using a single input
2022-09-01 16:07:26 -07:00
Henry Mercer
ab396da825
Run Lua tracing for Go on Windows in CLI 2.10.4+
...
A bug preventing us from using Lua tracing for Go on Windows is fixed
in CLI 2.10.4+, so we
can now resume using Lua tracing for Go on Windows when using these
CLI versions.
2022-09-01 16:58:23 +01:00
Henry Mercer
e460fa2e94
Tidy up createdDBForScannedLanguages
...
Now the test is fixed, we can simplify by introducing an async call.
2022-09-01 15:02:47 +01:00
Henry Mercer
6d34731d93
Make createdDBForScannedLanguages test robust to new async calls
...
Previously the test depended on `createdDBForScannedLanguages` making no
async calls prior to `codeql resolve extractor`.
2022-09-01 14:59:39 +01:00
Henry Mercer
cf5d465980
Trace Go when Go extraction reconciliation is enabled
2022-09-01 14:42:59 +01:00
Henry Mercer
fe1bd9ac76
Improve clarity of logging
2022-09-01 12:56:03 +01:00
Henry Mercer
8e0846caf0
Check TRAP directory exists first
2022-08-31 13:22:39 +01:00
Henry Mercer
955290300a
Fix language inclusion test
...
`in` checks the indices of an array, not the values.
2022-08-31 13:20:41 +01:00
Henry Mercer
14d7039828
Add logging for determining whether to run the Go autobuilder
2022-08-31 13:20:02 +01:00
Henry Mercer
b42a495e8a
Fix TRAP directory location
2022-08-31 13:19:16 +01:00
Henry Mercer
e466e75875
Simplify doesGoExtractionOutputExist implementation
...
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
2022-08-31 13:19:16 +01:00
Henry Mercer
fff56ee004
Add environment variable for enabling Go extraction reconcilation
...
This will enable us to test this behavior in PR checks.
Also simplify and add some more detailed documentation.
2022-08-31 13:19:16 +01:00
Henry Mercer
8dc468564f
Use a more explicit name for checking Go extraction output
2022-08-31 13:19:16 +01:00
Angela P Wen
215c3cb4bb
Autobuild Go in analyze step
2022-08-31 13:19:16 +01:00
Edoardo Pirovano
693b97bf50
Bump CodeQL version to 2.10.4
2022-08-31 11:49:32 +01:00
Andrew Eisenberg
0e98efa2bb
Add support for downloading packs from GHES
...
This change adds:
- new `registries` block allowed in code scanning config file
- new `registries-auth-tokens` input in init action
- Change the downloadPacks function so that it accepts new parameters:
- registries block
- api auth
- Generate a qlconfig.yml file with the registries block if one is
supplied. Use this file when downloading packs.
- temporarily set the `GITHUB_TOKEN` and `CODEQL_REGISTRIES_AUTH` based
on api auth
TODO:
1. integration test
2. handle pack downloads when the config is generated by the CLI
2022-08-30 10:04:30 -07:00
Andrew Eisenberg
7294b404d8
Fix call to endGroup
...
Also, rename variable and change a comment.
2022-08-30 09:16:05 -07:00
Andrew Eisenberg
0a2b0d236c
Moves calls to pack download to the init action
...
This ensures all steps to gather queries happens in the init action.
This is where checking out queries in other repos happens as well.
2022-08-26 16:04:57 -07:00
Chris Gavin
5960bffd3f
When running on a schedule, make a better guess about whether we're analyzing the default branch.
2022-08-25 10:58:16 +01:00
Edoardo Pirovano
8b45ef3845
Telemetry: Record DB creation time
2022-08-24 14:31:37 +01:00
Henry Mercer
e195431677
Override CODEQL_EXTRACTOR_GO_BUILD_TRACING with on when it's true
2022-08-24 11:48:32 +01:00
Henry Mercer
ab6508ab87
Disable Lua tracing for Go on Windows
...
This is currently broken in CLI versions 2.10.3 and earlier.
2022-08-23 20:03:33 +01:00
Henry Mercer
c18ed56977
Warn about invalid value for CODEQL_EXTRACTOR_GO_BUILD_TRACING
2022-08-23 20:03:33 +01:00
Andrew Eisenberg
ac92a02de7
Merge remote-tracking branch 'upstream/main' into aeisenberg/better-error-message
2022-08-23 09:29:19 -07:00
Andrew Eisenberg
5861352d57
Better error messages for invalid queries and query filters blocks
...
Handle other cases where the config is invalid.
2022-08-23 09:25:59 -07:00
Edoardo Pirovano
1e5376ae5f
TRAP Caching: Unset missing cache rather than setting to undefined
2022-08-23 15:39:05 +01:00
Henry Mercer
c72f566aae
Explicitly import performance for Node 12 compatibility
2022-08-22 12:59:22 +01:00
Edoardo Pirovano
0349bb05b7
Fix TRAP cache upload timing
2022-08-17 15:49:57 +01:00
Henry Mercer
b21cab99b3
Mock expect-error input to avoid errors in Action integration tests
2022-08-17 15:02:46 +01:00
Henry Mercer
219a937551
Require test mode to be set to use expect-error input
...
This should be more robust than determining whether the repo is the
CodeQL Action or a fork of it.
2022-08-17 14:49:24 +01:00
Edoardo Pirovano
eb6f272155
Round fields in TRAP caching telemetry to integers
2022-08-17 13:30:17 +01:00
Henry Mercer
b469d5358f
Tweak debug logging message
2022-08-17 12:44:53 +01:00
Henry Mercer
f47f573e6e
Add a debug log message when forcing the latest tools
2022-08-17 12:33:58 +01:00
Henry Mercer
416ad3d847
Merge branch 'main' into henrymercer/bypass-toolcache-feature-flag
2022-08-17 11:39:33 +01:00
