Angela P Wen
aa0e650c6a
Surface fatal CLI errors in interpret-results and run-queries ( #1407 )
...
Co-authored-by: Henry Mercer <henry.mercer@me.com >
2022-12-02 14:05:21 +01:00
Angela P Wen
9af9a11da8
Stop running fallback Go autobuild if database is finalized ( #1405 )
2022-12-01 11:29:03 +01:00
Henry Mercer
39fe7aa8a1
Remove dead guard for GHES 3.0
2022-11-23 13:57:07 +00:00
Andrew Eisenberg
c29fca48a1
Cache feature flags on disk
...
This will allow feature flags to be shared across steps in the same job,
avoiding an error we saw earlier where the init action had the flag
enabled, but the analyze step had it disabled.
This uses the runner's temp folder to cache the flags file, which will
stick around until the job completes.
2022-11-21 11:14:38 -08:00
Henry Mercer
0dea34e91c
Merge branch 'main' into henrymercer/delete-runner-part-2
2022-11-15 19:35:30 +00:00
Angela P Wen
5883c13406
Deprecate Go extraction reconciliation feature flag and CODEQL_EXTRACTOR_GO_BUILD_TRACING for custom builds ( #1322 )
...
Co-authored-by: Henry Mercer <henry.mercer@me.com >
2022-11-14 13:54:35 -08:00
Henry Mercer
9df773d1a3
Remove unneeded apiDetails input to getApiClient
2022-11-14 19:55:30 +00:00
Henry Mercer
b498c79130
Remove concept of Actions / runner mode
2022-11-14 16:37:48 +00:00
Edoardo Pirovano
d6f6ef4b0b
Force exit of process if a timeout has occurred
2022-11-09 17:28:15 +00:00
Andrew Eisenberg
701cea34ba
More renaming
2022-10-11 10:39:40 -07:00
Andrew Eisenberg
1a17c59fb0
More renaming
...
Avoid usage of "Feature Flag" unless we are talking specifically about
the response from github features api. Otherwise, use terms like
"Toggleable features".
Note both "toggleable" and "togglable" appear to be valid spellings of
the word. I chose the first for no good reason.
2022-10-07 11:33:32 -07:00
Andrew Eisenberg
b27aed78f5
Extract GitHubFeatureFlags to a separate class
...
Internal refactoring so that `GitHubFeatureFlags` is
private only. The public facing class is `Features`.
2022-10-06 18:00:40 -07:00
Andrew Eisenberg
e37b0d6470
Add the CliConfigFileEnabled feature flag
...
Also, wire it up to the `useCodeScanningConfigInCli` function.
2022-09-27 07:58:31 -07:00
Henry Mercer
0d2fa3c636
Support autobuilding multiple languages in autobuild Action
2022-09-12 17:35:32 +01:00
Henry Mercer
fc2f344141
Reuse getApiDetails code
2022-09-02 19:59:18 +01:00
Henry Mercer
cf5d465980
Trace Go when Go extraction reconciliation is enabled
2022-09-01 14:42:59 +01:00
Henry Mercer
fe1bd9ac76
Improve clarity of logging
2022-09-01 12:56:03 +01:00
Henry Mercer
8e0846caf0
Check TRAP directory exists first
2022-08-31 13:22:39 +01:00
Henry Mercer
955290300a
Fix language inclusion test
...
`in` checks the indices of an array, not the values.
2022-08-31 13:20:41 +01:00
Henry Mercer
14d7039828
Add logging for determining whether to run the Go autobuilder
2022-08-31 13:20:02 +01:00
Henry Mercer
b42a495e8a
Fix TRAP directory location
2022-08-31 13:19:16 +01:00
Henry Mercer
e466e75875
Simplify doesGoExtractionOutputExist implementation
...
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
2022-08-31 13:19:16 +01:00
Henry Mercer
fff56ee004
Add environment variable for enabling Go extraction reconcilation
...
This will enable us to test this behavior in PR checks.
Also simplify and add some more detailed documentation.
2022-08-31 13:19:16 +01:00
Henry Mercer
8dc468564f
Use a more explicit name for checking Go extraction output
2022-08-31 13:19:16 +01:00
Angela P Wen
215c3cb4bb
Autobuild Go in analyze step
2022-08-31 13:19:16 +01:00
Edoardo Pirovano
8b45ef3845
Telemetry: Record DB creation time
2022-08-24 14:31:37 +01:00
Henry Mercer
c72f566aae
Explicitly import performance for Node 12 compatibility
2022-08-22 12:59:22 +01:00
Edoardo Pirovano
0349bb05b7
Fix TRAP cache upload timing
2022-08-17 15:49:57 +01:00
Henry Mercer
219a937551
Require test mode to be set to use expect-error input
...
This should be more robust than determining whether the repo is the
CodeQL Action or a fork of it.
2022-08-17 14:49:24 +01:00
Edoardo Pirovano
eb6f272155
Round fields in TRAP caching telemetry to integers
2022-08-17 13:30:17 +01:00
Angela P Wen
9b7fa3dd99
Add expect-error input to force PR check green on expected failure ( #1177 )
2022-08-16 16:27:14 -07:00
Edoardo Pirovano
b29194f0ac
Address review comments from @henrymercer
2022-08-16 13:30:49 +01:00
Edoardo Pirovano
4139682b64
Add telemetry for TRAP caching
2022-08-16 11:54:31 +01:00
Chris Gavin
07e8996e91
Merge main into local.
2022-08-11 17:11:05 +01:00
Chris Gavin
bbdc9efa94
Use the API URL from the environment if it is present.
2022-08-11 08:38:11 +01:00
Angela P Wen
3c4f458a1a
Re-declare codeql var
2022-08-10 15:08:35 +02:00
Angela P Wen
90676d9cb9
Merge remote-tracking branch 'origin/main' into angelapwen/post-init-cleanup
2022-08-10 15:08:04 +02:00
Edoardo Pirovano
8f867dcb21
Introduce TRAP caching
2022-08-05 17:48:05 +01:00
Angela P Wen
2746051310
Catch case where database isn't finalized
2022-07-29 12:00:07 +02:00
Angela P Wen
1016eba538
Move logs, SARIF actions uploads to post: hooks
2022-07-29 11:29:39 +02:00
Andrew Eisenberg
7ce9ef9137
Use concat instead of push around listFolders
...
This avoids stack overflows when using the spread operator on
directories that have many, many children.
2022-07-12 13:23:01 -07:00
Henry Mercer
b45ac1f8f8
Cleanup: Use optional chaining in a couple of places
2022-07-12 16:30:21 +01:00
Henry Mercer
53850d88bb
Enable one-click debugging via the "Enable debug logging" rerun option
2022-07-01 17:56:57 +01:00
Cornelius Riemenschneider
f422a50448
Honor the Lua tracer FF for database trace-command invocations for scanned languages.
...
In theory, a scanned language will not setup the build tracer, and so
shouldn't care about lua versus legacy tracing. However, `go` is a
special case where the autobuilder runs under the build tracer, that
then gets disabled immediately again, unless a special environment
variable is used.
Therefore, we need to thread through the feature flag to this
`database trace-command` invocation. For other scanned languages,
this should be a no-op, as no tracing is ever set up.
2022-06-27 16:04:29 +00:00
Henry Mercer
ea676e3184
Don't wait for processing in test mode
...
In test mode, we don't upload results, so there's no point waiting for
processing.
2022-04-28 19:14:14 +01:00
Henry Mercer
0256599547
Prompt customers to upgrade from v1 to v2
2022-04-27 16:11:24 +01:00
Andrew Eisenberg
3d93bb2ac9
Add UserError
...
This commit adds a `UserError` class that should be thrown when the
cause of an error is fundamentally from user configuration.
When sending status reports, avoid sending a `failure` for `UserError`s.
This will prevent our diagnostics from pinging us for errors outside of
our control.
2022-02-17 11:47:31 -08:00
Henry Mercer
feb711fe0b
Merge branch 'main' into henrymercer/add-ml-powered-query-enablement-to-analyze-status-report
2022-02-15 17:31:07 +00:00
Henry Mercer
bcdaad245b
Add ML-powered query enablement info to analyze finish status report
2022-02-15 15:04:23 +00:00
Robert
8aa32bd9c9
Remove check of database uploads feature flag
2022-02-15 14:10:33 +00:00
