Andrew Eisenberg
98d24e5629
Address comments from PR
2023-02-27 09:59:16 -08:00
Andrew Eisenberg
8f19113f88
Merge branch 'main' into aeisenberg/qlconfig-in-cli
2023-02-26 18:35:21 -08:00
Alexander Eyers-Taylor
237a258d2b
Merge pull request #1543 from github/alexet/update-2.12.3
...
Update default CodeQL bundle version to 2.12.3
2023-02-23 15:46:39 +00:00
Alexander Eyers-Taylor
5972e6d72e
Fix lib file
2023-02-22 18:38:46 +00:00
Alexander Eyers-Taylor
164027e682
Fix bundle versions
2023-02-22 18:18:37 +00:00
Chuan-kai Lin
d7d7567b0e
Unit tests for optimizeForLastQueryRun
2023-02-17 11:19:38 -08:00
Chuan-kai Lin
0e4e857bab
Set optimizeForLastQueryRun on last run
2023-02-17 11:17:42 -08:00
Chuan-kai Lin
08d1f21d4f
Calculate customQueryIndices early
...
This refactoring commit changes runQueries() to calculate the set of
indices with non-empty custom queries early. Doing so allows us to check
early on whether there are any custom queries to run.
2023-02-17 11:14:08 -08:00
Alexander Eyers-Taylor
d87ad69338
Update default CodeQL bundle version to 2.12.3
2023-02-17 15:49:39 +00:00
Chuan-kai Lin
8242edb8ed
databaseRunQueries(): add optimizeForLastQueryRun parameter
2023-02-15 08:45:13 -08:00
Chuan-kai Lin
3095a09bb0
databaseRunQueries(): accept a list of flags
...
This refactoring commit changes databaseRunQueries() to accept a list of
flags instead of separate memory and threads flags.
2023-02-14 11:53:52 -08:00
Andrew Eisenberg
e00cd12e3e
Merge pull request #1539 from github/aeisenberg/unref-delay
...
Avoid unref-ing timer while awaiting status upload
2023-02-13 15:24:43 -08:00
Angela P Wen
a25536bc80
Optionally send tools download telemetry ( #1538 )
2023-02-13 21:45:54 +00:00
Andrew Eisenberg
a2487fb969
Avoid unref-ing timer while awaiting status upload
...
We had a problem where `waitForProcessing` was not completing before
the node process ends. This is because using `unref` would allow the
node process to end without having the `delay` function complete.
2023-02-13 13:43:18 -08:00
Chuan-kai Lin
b011dbdedf
Remove TRAP caching feature flag
2023-02-10 09:27:16 -08:00
Angela P Wen
40babc141f
Tools telemetry: accurately report when feature flags were inaccessible ( #1532 )
...
* Cache whether feature flags are accessible
* Small comment fixup from linting change
2023-02-10 09:06:43 -08:00
Andrew Eisenberg
5492b7d104
Add tests for generateRegistries with an existing CODEQL_REGISTRIES_AUTH
2023-02-09 13:37:08 -08:00
Andrew Eisenberg
3c81243bb1
Apply suggestions from code review
...
Co-authored-by: Henry Mercer <henry.mercer@me.com >
2023-02-09 12:25:33 -08:00
Andrew Eisenberg
e2f72f11e4
Merge remote-tracking branch 'upstream/main' into aeisenberg/qlconfig-in-cli
2023-02-09 09:47:43 -08:00
Henry Mercer
db534af2ae
Remove feature flags for bypassing the toolcache
...
- We can now use the default bundle version feature flags to remediate a
bad bundle update.
- Controlled switchover ensures that a repo consistently gets the same
bundle version, so we no longer have alert churn concerns with Kotlin
and Swift.
2023-02-08 15:20:51 +00:00
Andrew Eisenberg
bbe8d375fd
Ensure qlconfig file is created when config parsing in cli is on
...
Previously, with the config parsing in the cli feature flag turned on,
the CLI was not able to download packs from other registries. This PR
adds the codeql-action changes required for this. The CLI changes will
be in a separate, internal PR.
2023-02-07 10:40:56 -08:00
Chuan-kai Lin
4f08c2cf20
Bump default CodeQL version to 2.12.2
2023-02-07 08:10:01 -08:00
Angela P Wen
81644f35ff
Add max line length of 120 to linter ( #1524 )
2023-02-07 14:09:33 +00:00
Angela P Wen
39c954c513
Support security-experimental as a well-known suite ( #1519 )
2023-02-06 19:26:03 +00:00
Henry Mercer
2b674f7ab9
Fix toolcache behavior when downloading bundle from another repo
2023-02-06 16:25:07 +00:00
Henry Mercer
6d47a7c8b1
Add regression test for bundle from different repo
2023-02-06 16:25:07 +00:00
Henry Mercer
d3f2b2e6d2
Warn when multiple bundles for a single CLI are found in the toolcache
2023-02-06 12:28:33 +00:00
Henry Mercer
d49282c3b5
Rename forceLatest to forceShippedTools
2023-02-06 11:57:48 +00:00
Henry Mercer
f140af5e28
Refactor setting up CodeQL to handle bundle URLs without tags
2023-02-03 19:15:06 +00:00
Henry Mercer
e0fc1c91b2
Add regression test for a bundle URL without a tag
2023-02-03 19:13:24 +00:00
Arthur Baars
2fed02cbe2
Supply authorization parameter to toolcache.downloadTool()
...
Previously we supplied the authorization information via the 'headers'
parameter. This works fine, except in some cases when the request is
retried.
2023-02-03 14:56:00 +01:00
Angela P Wen
4664f39699
Ensure that tools_download_duration_ms is int ( #1513 )
2023-01-27 09:03:57 +00:00
Henry Mercer
75ae065ae6
Fix computation of fallback version
2023-01-26 11:49:51 +00:00
Henry Mercer
0a9e9db27f
Add failing regression test
2023-01-26 11:49:24 +00:00
Angela P Wen
24ca6b0400
Send tools telemetry to init status report ( #1497 )
...
Co-authored-by: Henry Mercer <henry.mercer@me.com >
2023-01-25 11:09:18 -08:00
Henry Mercer
a58e90a9da
Merge pull request #1508 from github/henrymercer/default-version-fallback
...
Fall back to the `defaults.json` CLI version if feature flags misconfigured
2023-01-24 20:01:47 +00:00
Henry Mercer
5d931ea2a2
Fall back to the default.json CLI version if feature flags misconfigured
2023-01-23 20:00:44 +00:00
Henry Mercer
ebdd5a069f
Remove perf_hooks Node 12 comment
...
We don't need the import for Node 12 compat, but we do need it to make
the file compile.
2023-01-23 19:16:03 +00:00
Henry Mercer
d37dce28f6
Bump default CodeQL version to 2.12.1
2023-01-23 11:25:09 +00:00
Henry Mercer
54f4ea7a62
Merge branch 'main' into henrymercer/no-cache-nightlies
2023-01-20 17:35:04 +00:00
Henry Mercer
8e4a1d6e60
Merge branch 'main' into henrymercer/avoid-waiting-for-timeout
2023-01-20 16:29:49 +00:00
Henry Mercer
291cc75959
Add test case
2023-01-20 15:30:57 +00:00
Henry Mercer
2014c859f1
Increase strictness of tool caching threshold to avoid caching nightlies
2023-01-20 15:23:27 +00:00
Henry Mercer
4beb39593b
Explain why we're using --format=json to get the extractor path
2023-01-20 15:01:38 +00:00
Henry Mercer
be8f7b01a2
Add types for package.json via @schemastore/package
2023-01-20 15:01:35 +00:00
Henry Mercer
1b508953b4
Remove checkActionVersion
...
This is no longer needed now that we only release v2
2023-01-20 15:01:35 +00:00
Henry Mercer
cb9be70046
Install @types/uuid and eliminate a cast
2023-01-20 15:01:35 +00:00
Henry Mercer
85f0d840c9
Use a more Promise-oriented approach for the timeout system
2023-01-19 20:25:55 +00:00
Henry Mercer
b61b299591
Immediately unref timers to avoid waiting for them before exit
2023-01-19 18:09:06 +00:00
Henry Mercer
ba93815e25
Merge branch 'main' into henrymercer/upgrade-typescript
2023-01-19 16:15:51 +00:00