Henry Mercer
43c3ed9c28
More feature flag renaming
2022-10-11 11:52:55 -07:00
Andrew Eisenberg
701cea34ba
More renaming
2022-10-11 10:39:40 -07:00
Edoardo Pirovano
adb28963c0
Further update to reflect a conversation with @henrymercer
2022-10-11 16:59:48 +01:00
alexet
362f9a2522
Update bundle for 2.11.1
...
This version has the fix applied
2022-10-11 12:05:46 +01:00
Edoardo Pirovano
6e1dab28b6
Fix withTimeout helper function
2022-10-11 10:04:21 +01:00
Andrew Eisenberg
6c869f8b03
Fix typos
2022-10-07 16:27:25 -07:00
Andrew Eisenberg
919e4caca1
Merge remote-tracking branch 'upstream/main' into aeisenberg/ff-refactoring
2022-10-07 14:14:09 -07:00
Andrew Eisenberg
1a17c59fb0
More renaming
...
Avoid usage of "Feature Flag" unless we are talking specifically about
the response from github features api. Otherwise, use terms like
"Toggleable features".
Note both "toggleable" and "togglable" appear to be valid spellings of
the word. I chose the first for no good reason.
2022-10-07 11:33:32 -07:00
Andrew Eisenberg
b27aed78f5
Extract GitHubFeatureFlags to a separate class
...
Internal refactoring so that `GitHubFeatureFlags` is
private only. The public facing class is `Features`.
2022-10-06 18:00:40 -07:00
Andrew Eisenberg
5915e70486
Address comments from review
2022-10-06 13:14:06 -07:00
Andrew Eisenberg
6de05e4b24
Rename FeatureFlag -> Feature
2022-10-06 13:06:10 -07:00
Andrew Eisenberg
b16314e16c
Address comments from review
...
- Change env var name for `MlPoweredQueriesEnabled`
- Throw error if minimumVersion is specified, but CodeQL argument is not
supplied.
- Fix failing tests. Note that I removed a config-utils test because it
is no longer relevant since we handle codeql minimum versions in the
`getValue` function.
2022-10-06 12:29:58 -07:00
Andrew Eisenberg
84dffe700c
Merge pull request #1282 from github/aeisenberg/user-error-source-root
...
Convert "Invalid source root" errors to UserErrors
2022-10-06 10:48:35 -07:00
Andrew Eisenberg
9e044c5432
Convert "Invalid source root" errors to UserErrors
2022-10-06 09:28:29 -07:00
Andrew Eisenberg
e5c3375225
Refactor handling of feature flags
...
This commit centralizes how feature flags are handled. All feature flags
must now add an entry in the `featureFlagConfig` dictionary. This
dictionary associates the flag with an environment variable name and
optionally a minimum version for CodeQL.
The new logic is:
- if the environment variable is set to false: disabled
- if the minimum version requirement specified and met: disabled
- if the environment variable is set to true: enable
- Otherwise check feature flag enablement from the server
2022-10-05 16:40:56 -07:00
Angela P Wen
24c8de16fa
Correctly report CodeQL version when using cache ( #1259 )
...
* Correctly report CodeQL version when using cache
* Add JS generated files
* Add test for return value of `setupCodeQL`
* Fill in missing return value comment
2022-10-05 09:16:42 -07:00
Andrew Eisenberg
5960ce1190
Extract logging statements to separate function
2022-10-03 09:35:40 -07:00
Andrew Eisenberg
6ace05baa3
Add logging statements declaring state of the cli_config_file_enabled
...
It's possible to determine this otherwise, but this makes it easier to
spot.
2022-10-01 12:03:01 -07:00
Edoardo Pirovano
c0641ea1d3
TRAP Caching: Add timeouts to upload/download operations
2022-09-30 13:18:46 +01:00
github-actions[bot]
61b87c69a6
Update supported GitHub Enterprise Server versions. ( #1275 )
...
Co-authored-by: GitHub <noreply@github.com >
2022-09-29 22:37:10 +00:00
Andrew Eisenberg
1ec8ea99ee
Merge branch 'main' into aeisenberg/cli-config-feature-flag
2022-09-28 10:39:05 -07:00
Chuan-kai Lin
a711c7623d
Update default CodeQL version to 2.11.0
2022-09-28 09:04:11 -07:00
Henry Mercer
39064e0f9b
Merge pull request #1272 from github/update-supported-enterprise-server-versions
...
Update supported GitHub Enterprise Server versions.
2022-09-28 10:52:55 +01:00
Edoardo Pirovano
28c63d131f
Merge pull request #1268 from jsoref/rev-parse
...
Correct program name
2022-09-28 09:59:29 +01:00
Josh Soref
a4e4529299
Correct program name
2022-09-27 22:08:31 -04:00
GitHub
cc4ee05a07
Update supported GitHub Enterprise Server versions.
2022-09-28 00:21:45 +00:00
Andrew Eisenberg
cab46c529f
Update src/util.test.ts
2022-09-27 15:49:25 -07:00
Andrew Eisenberg
e37b0d6470
Add the CliConfigFileEnabled feature flag
...
Also, wire it up to the `useCodeScanningConfigInCli` function.
2022-09-27 07:58:31 -07:00
Edoardo Pirovano
b96c7546c1
Fix broken unit test
2022-09-26 15:17:36 +01:00
Edoardo Pirovano
b98b2def63
TRAP Caching: Skip uploading of small caches
2022-09-23 15:22:31 +01:00
Henry Mercer
34aa5a554b
Merge pull request #1242 from github/henrymercer/go-more-backwards-compat
...
Go extraction reconciliation: Ensure backwards compatibility for multi-language builds
2022-09-16 11:05:41 +01:00
Henry Mercer
f32e161cdd
Improve warning when using autobuild with multi-language builds
2022-09-13 16:53:02 +01:00
Henry Mercer
4cc95769d4
Improve variable name
2022-09-13 16:50:41 +01:00
Cornelius Riemenschneider
fd4dc5bf31
Merge pull request #1244 from github/criemen/remove-lua-tracer-ff
...
Remove the lua tracer feature flag check from the codeql-action.
2022-09-13 17:49:47 +02:00
Cornelius Riemenschneider
3038e979a8
Remove the lua tracer feature flag check from the codeql-action.
...
Always defer to the CLI on the Lua tracer state from now on.
2022-09-13 11:23:32 +00:00
Henry Mercer
bde5694fb7
Comment why we don't run multiple autobuilders for other languages
2022-09-12 18:25:20 +01:00
Henry Mercer
40e0374c6f
Ensure backwards compat for multi-language builds with Go reconciliation
2022-09-12 18:24:46 +01:00
Henry Mercer
0d2fa3c636
Support autobuilding multiple languages in autobuild Action
2022-09-12 17:35:32 +01:00
Henry Mercer
4a8d26e2bd
Bump CodeQL version to 2.10.5
2022-09-08 18:29:45 +01:00
Andrew Eisenberg
9ba4d500aa
Merge pull request #1221 from github/aeisenberg/ghes-pack-download
...
Add support for downloading packs from GHES
2022-09-08 10:02:41 -07:00
Andrew Eisenberg
6085805a3a
Append / to end of registries url
...
Avoids a bug in 2.10.4. Also, add some better handling for invalid
registries blocks.
2022-09-08 08:00:24 -07:00
Andrew Eisenberg
59744464eb
Fix unit tests
2022-09-07 16:10:34 -07:00
Andrew Eisenberg
4fa3e8b483
Gate the new registries input behind version constraints
2022-09-07 14:38:44 -07:00
David Verdeguer
063e083705
Fix linting
2022-09-07 22:45:34 +02:00
David Verdeguer
a03f3bd585
Build js
2022-09-07 09:45:19 +02:00
Andrew Eisenberg
376fea671d
Clarify description of registries input
2022-09-06 14:06:30 -07:00
Andrew Eisenberg
bf97a6da5b
Apply suggestions from code review
2022-09-06 10:41:32 -07:00
Andrew Eisenberg
7e086b240c
Merge remote-tracking branch 'upstream/main' into aeisenberg/ghes-pack-download
2022-09-06 10:22:00 -07:00
Edoardo Pirovano
299b77421b
TRAP Caching: Be tolerant to not finding the extractor
2022-09-05 10:38:21 +01:00
Andrew Eisenberg
abdf26c28f
Convert from json to yaml for registries input
2022-09-02 15:03:51 -07:00