Henry Mercer
69aec345f1
Pass negative SARIF include diagnostics flag when feature is disabled
...
In preparation for enabling this flag by default in the CLI
2023-03-29 18:56:19 +01:00
Henry Mercer
29a4713933
Enable diagnostics functionality on GHES
2023-03-29 18:45:27 +01:00
Robin Neatherway
f6e4cff38a
Remove checks for triggering on specific paths
...
These are no longer necessary with the new approach to selecting
alerts to show on pull requests.
2023-03-29 11:02:16 +02:00
Henry Mercer
57eca7cbb2
Use Array.isArray
2023-03-27 15:59:29 +01:00
Henry Mercer
1e7a38893c
Wrap reading and writing SARIF files
2023-03-27 15:44:47 +01:00
Henry Mercer
c8935d5a9d
Remove duplicate locations from failed run SARIF
2023-03-24 20:30:57 +00:00
Henry Mercer
ade432fd68
Remove duplicate locations from output of database interpret-results
2023-03-24 20:30:57 +00:00
Henry Mercer
6f852eeb38
Implement removing duplicate locations from a SARIF file
2023-03-24 20:30:57 +00:00
Angela P Wen
a21bb7f968
Update upload input values and logic ( #1598 )
...
- The `upload` input to the `analyze` Action now accepts the following values:
- `always` is the default value, which uploads the SARIF file to Code Scanning for successful and failed runs.
- `failure-only` is recommended for customers post-processing the SARIF file before uploading it to Code Scanning. This option uploads debugging information to Code Scanning for failed runs to improve the debugging experience.
- `never` avoids uploading the SARIF file to Code Scanning even if the code scanning run fails. This is not recommended for external users since it complicates debugging.
- The legacy `true` and `false` options will be interpreted as `always` and `failure-only` respectively.
---------
Co-authored-by: Henry Mercer <henry.mercer@me.com >
2023-03-23 17:23:25 +00:00
Charis Kyriakou
94cc1dea00
Add override for code scanning analysis of default branch
2023-03-23 13:31:00 +00:00
Henry Mercer
066b6343ef
Merge pull request #1599 from github/update-supported-enterprise-server-versions
...
Update supported GitHub Enterprise Server versions.
2023-03-22 18:26:37 +00:00
Robin Neatherway
3ca2260643
Account for versioning of ghe.com
2023-03-22 16:47:23 +00:00
GitHub
5f20b2c372
Update supported GitHub Enterprise Server versions.
2023-03-22 00:10:22 +00:00
Henry Mercer
86128131fa
Merge branch 'main' into henrymercer/bundle-2.12.5
2023-03-21 12:18:07 +00:00
Henry Mercer
ebbe965b43
Merge pull request #1588 from github/update-supported-enterprise-server-versions
...
Update supported GitHub Enterprise Server versions.
2023-03-21 00:04:32 +00:00
Angela P Wen
3cbd063679
Upload per-database diagnostic SARIFs on green and red runs ( #1556 )
...
Co-authored-by: Henry Mercer <henry.mercer@me.com >
2023-03-20 21:09:04 +00:00
GitHub
978bc50f9b
Update supported GitHub Enterprise Server versions.
2023-03-18 00:11:16 +00:00
Henry Mercer
98a90dcce7
Update default bundle version to 2.12.5
2023-03-17 13:42:17 +00:00
Henry Mercer
65f42e3768
Inline minimum version number to avoid circular dependency
2023-03-14 21:04:34 +00:00
Henry Mercer
d9ceda3823
Add debug logging for feature flag enablement
2023-03-14 20:57:55 +00:00
Henry Mercer
53f80edaf6
Merge branch 'main' into henrymercer/diagnostics-code-scanning-config
2023-03-09 18:47:43 +00:00
Henry Mercer
485cc11a24
Rename featureEnablement to features
...
This is more succinct and removes a few line breaks
2023-03-09 16:46:51 +00:00
Henry Mercer
fc1366f6ec
Gate config export behind a feature flag
2023-03-09 16:44:45 +00:00
Dave Bartolomeo
d47d4c8047
Merge branch 'main' into dbartol/bundle-2.12.4
2023-03-09 09:45:34 -05:00
Andrew Eisenberg
0c27d0da4a
Add default values to feature flags
...
This changes adds default values to feature flags. These default values
will be used whenever the full set of feature flags are not available
(for example on GHES or if the flag request fails).
The goal is to enable cli config parsing on GHES without removing the
feature flag on dotcom.
2023-03-07 16:24:55 -08:00
Henry Mercer
4b1f530308
Export configuration information for green runs
2023-03-07 21:22:43 +00:00
Henry Mercer
d98eadb536
Export configuration information for red runs
2023-03-07 21:21:47 +00:00
Henry Mercer
c310f094dd
Fix name of qlconfig file argument
2023-03-07 08:46:58 -08:00
Henry Mercer
4366485427
Avoid passing an undefined qlconfig arg
2023-03-07 08:46:57 -08:00
Henry Mercer
8340258886
Avoid writing user-config.yaml file while running tests
2023-03-07 08:46:57 -08:00
Henry Mercer
eb40427b00
Fix name of qlconfig file argument
2023-03-06 10:48:14 +00:00
Henry Mercer
100bd7bbef
Avoid passing an undefined qlconfig arg
2023-03-06 10:26:34 +00:00
Henry Mercer
a6d3a44519
Avoid writing user-config.yaml file while running tests
2023-03-06 10:23:28 +00:00
Dave Bartolomeo
e812e63bb6
Update bundle to 2.12.4
2023-03-05 20:50:59 -05:00
Andrew Eisenberg
98d24e5629
Address comments from PR
2023-02-27 09:59:16 -08:00
Andrew Eisenberg
8f19113f88
Merge branch 'main' into aeisenberg/qlconfig-in-cli
2023-02-26 18:35:21 -08:00
Alexander Eyers-Taylor
237a258d2b
Merge pull request #1543 from github/alexet/update-2.12.3
...
Update default CodeQL bundle version to 2.12.3
2023-02-23 15:46:39 +00:00
Alexander Eyers-Taylor
5972e6d72e
Fix lib file
2023-02-22 18:38:46 +00:00
Alexander Eyers-Taylor
164027e682
Fix bundle versions
2023-02-22 18:18:37 +00:00
Chuan-kai Lin
d7d7567b0e
Unit tests for optimizeForLastQueryRun
2023-02-17 11:19:38 -08:00
Chuan-kai Lin
0e4e857bab
Set optimizeForLastQueryRun on last run
2023-02-17 11:17:42 -08:00
Chuan-kai Lin
08d1f21d4f
Calculate customQueryIndices early
...
This refactoring commit changes runQueries() to calculate the set of
indices with non-empty custom queries early. Doing so allows us to check
early on whether there are any custom queries to run.
2023-02-17 11:14:08 -08:00
Alexander Eyers-Taylor
d87ad69338
Update default CodeQL bundle version to 2.12.3
2023-02-17 15:49:39 +00:00
Chuan-kai Lin
8242edb8ed
databaseRunQueries(): add optimizeForLastQueryRun parameter
2023-02-15 08:45:13 -08:00
Chuan-kai Lin
3095a09bb0
databaseRunQueries(): accept a list of flags
...
This refactoring commit changes databaseRunQueries() to accept a list of
flags instead of separate memory and threads flags.
2023-02-14 11:53:52 -08:00
Andrew Eisenberg
e00cd12e3e
Merge pull request #1539 from github/aeisenberg/unref-delay
...
Avoid unref-ing timer while awaiting status upload
2023-02-13 15:24:43 -08:00
Angela P Wen
a25536bc80
Optionally send tools download telemetry ( #1538 )
2023-02-13 21:45:54 +00:00
Andrew Eisenberg
a2487fb969
Avoid unref-ing timer while awaiting status upload
...
We had a problem where `waitForProcessing` was not completing before
the node process ends. This is because using `unref` would allow the
node process to end without having the `delay` function complete.
2023-02-13 13:43:18 -08:00
Chuan-kai Lin
b011dbdedf
Remove TRAP caching feature flag
2023-02-10 09:27:16 -08:00
Angela P Wen
40babc141f
Tools telemetry: accurately report when feature flags were inaccessible ( #1532 )
...
* Cache whether feature flags are accessible
* Small comment fixup from linting change
2023-02-10 09:06:43 -08:00