Eric Cornelissen
74559947b1
Fix no shadow issues in fingerprints.ts
...
Rename various instances of "hash", shadowing the function with that
name.
2020-11-19 22:54:05 +01:00
Eric Cornelissen
ffe94681e4
Fix no shadow issues in fingerprints.test.ts
...
Rename shadowing "uri" argument to the more explicit "artifactURI".
2020-11-19 22:51:29 +01:00
Eric Cornelissen
2a2910e693
Fix no shadow issues in config-utils.ts
...
Rename throwaway variable "suite" to "found" when assigned from "find".
Rename local variable "path" to "newPath" as it is a modification of
the "originalPath" provided to `validateAndSanitisePath`.
Rename instances of "path" to more explicit varients "ignorePath" and
"includePath". Maybe "ignoredPath" and "includedPath" are better names?
2020-11-19 22:50:02 +01:00
Eric Cornelissen
06e99f1523
Fix no shadow issues in config-utils.test.ts
...
Rename "queries" variable in test cases to "testQueries" to avoid
shadowing it in a subsequent helper function call (4 times).
Rename "path" twice in a hlper function to "validPath" and "invalidPath"
to avoid shadowing "path". The new names are more explicit.
2020-11-19 22:47:32 +01:00
Eric Cornelissen
98ad63b240
Fix no shadow issues in codeql.ts
...
Two simple variable renames from "path" to "paths" since the types are
arrays of strings (not just one string).
One function definition inside a function moved outside that function
to avoid shadowing the "options" argument.
2020-11-19 22:45:15 +01:00
Eric Cornelissen
b54c2aab11
Fix no shadow issues in api-client.ts
...
Duplicate use of "_" placeholder argument name. This change may conflict
with #192 .
2020-11-19 22:42:13 +01:00
Eric Cornelissen
22f779c5e6
Update ESLint configuration
...
Remove the "no-shadow": "off" override and replace it by enabling
"@typescript-eslint/no-shadow" in the "rules" section, following the
typescript-eslint docs:
https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-shadow.md#how-to-use
2020-11-19 22:38:38 +01:00
Robert
aafb457527
Merge pull request #222 from github/robertbrignull/go_build_trace
...
Check CODEQL_EXTRACTOR_GO_TRACE and treat Go as a traced language
2020-11-19 18:01:53 +00:00
Robert
0b0bc35050
Merge branch 'main' into robertbrignull/go_build_trace
2020-11-19 17:20:54 +00:00
Simon Engledew
eb4226ede4
Scanning endpoint failures should not halt the scan
2020-11-19 15:49:46 +00:00
Simon Engledew
7fda765d49
Merge remote-tracking branch 'origin/main' into simon-engledew/fast-fail
2020-11-19 13:55:47 +00:00
Chris Gavin
0924fb6b26
Merge pull request #309 from github/safe-which
...
Ensure unqualified program names are present on `PATH` before executing them.
2020-11-19 13:52:57 +00:00
Simon Engledew
17d4671d60
Fail processing on a 422 as well
...
Until there is a more robust versioning system it is probably safest to require endpoint compatiblity and not continue the action if there is a mismatch.
2020-11-19 13:14:45 +00:00
Simon Engledew
f3ff4c84ba
Implement review feedback
2020-11-19 12:39:57 +00:00
Chris Gavin
726cfc8441
Ensure unqualified program names are present on PATH before executing them.
2020-11-18 22:20:13 +00:00
Simon Engledew
68dedeaa57
Do not run CodeQL if code scanning is not enabled
...
Put more fine grained logic around which errors we ignore and process.
Re-instate status reporting in Enterprise.
Abort the code scanning process the status endpoint reports it is not configured.
2020-11-18 17:21:57 +00:00
Robert
dc80b016b6
Merge pull request #301 from github/robertbrignull/tools_version
...
Send action ref and tool version in status reports
2020-11-18 11:38:26 +00:00
Robert
0d960df08a
Merge branch 'main' into robertbrignull/tools_version
2020-11-18 11:25:46 +00:00
Chris Gavin
10b43b815a
Merge pull request #231 from github/add-multi-cause-markdown-flag
...
Enable the CodeQL SARIF multi-cause markdown flag.
2020-11-18 08:39:30 +00:00
Chris Gavin
f94e06a382
Merge main into add-multi-cause-markdown-flag.
2020-11-18 08:26:39 +00:00
Robert
577fc451dd
Merge pull request #306 from github/update-v1-d4eb1e36
...
Merge main into v1
2020-11-16 12:03:04 +00:00
Robert
d4eb1e36af
Merge pull request #302 from github/robertbrignull/no_tracing
...
Don't use the word "trace" in log messages
2020-11-13 15:27:37 +00:00
Robert
54c857ce0a
update build command
2020-11-13 15:15:58 +00:00
Robert
3f2a7abc7b
change voicing
2020-11-13 15:04:54 +00:00
Robert
e3a9a7a91c
Update init/action.yml
...
Co-authored-by: Sam Partington <sampart@github.com >
2020-11-13 12:51:25 +00:00
Robert
4d8912d269
Don't use the word "trace" in log messages
2020-11-13 12:01:07 +00:00
Robert
af27146b64
Merge branch 'main' into robertbrignull/go_build_trace
2020-11-13 10:24:37 +00:00
Robert
1737b806ff
check if running locally
2020-11-12 14:18:58 +00:00
Robert
80b43ca9d3
send action ref and tool version in status reports
2020-11-12 12:27:31 +00:00
Robert
acacf9bbd5
Merge pull request #299 from github/azure_pipelines
...
Detect Agent.Worker.exe
2020-11-11 10:28:25 +00:00
Robert
9a7b7cb035
Merge branch 'main' into azure_pipelines
2020-11-11 10:12:56 +00:00
Chris Gavin
fdb0d486b6
Merge pull request #298 from github/use-github-action-repository-variable
...
Make use of the `GITHUB_ACTION_REPOSITORY` environment variable if it is set.
2020-11-10 18:13:50 +00:00
Chris Gavin
241fca876b
Merge branch 'main' into use-github-action-repository-variable
2020-11-10 17:55:13 +00:00
Robert
aae4713a4d
detect Agent.Worker.exe
2020-11-10 16:16:58 +00:00
Robin Neatherway
d3285a0ea2
Merge pull request #297 from github/rneatherway-patch-1
...
Change suggested workflow to analyse merge commit
2020-11-10 14:46:28 +00:00
Chris Gavin
bf30ea69d6
Make use of the GITHUB_ACTION_REPOSITORY environment variable if it is set.
2020-11-10 13:30:20 +00:00
Robin Neatherway
988704e971
Change suggested workflow to analyse merge commit
2020-11-10 12:10:07 +00:00
Robert
409b71a3d0
Merge pull request #296 from 0xflotus/patch-1
...
fix: small typo in import-action-entrypoint.ql
2020-11-10 09:34:24 +00:00
0xflotus
1870040fac
fix: small typo in import-action-entrypoint.ql
2020-11-10 00:38:46 +01:00
Robin Neatherway
1de54f1d3b
Merge pull request #295 from github/main
...
Update v1 with new CodeQL bundle
2020-11-09 15:42:20 +00:00
Robin Neatherway
4b301bd34e
Merge pull request #294 from github/rneatherway/bump-codeql-20201106
...
Update default CodeQL bundle version
2020-11-09 14:05:10 +00:00
Robin Neatherway
ab40235d88
Update default CodeQL bundle version
2020-11-09 13:00:43 +00:00
Simon Engledew
e3bfd25a41
Merge pull request #293 from github/update-v1-f13bd452
...
Merge main into v1
2020-11-09 10:22:41 +00:00
Simon Engledew
f13bd452d7
Merge pull request #291 from github/simon-engledew/output-codeql-path
...
Add a codeql-path output to the init action
codeql-bundle-20201106
2020-11-05 10:22:10 +00:00
Simon Engledew
f76124122e
Remove output from README
...
As this is an advanced usage it makes more sense to work to getting this included in the documentation instead.
2020-11-05 08:31:35 +00:00
Simon Engledew
c87f3021d4
Expand readme to include codeql-path output example
...
Also add example from README into workflow to confirm it is accurate.
2020-11-04 19:35:19 +00:00
Simon Engledew
54f3e52e8f
Move setOutput into try block in case it errors
2020-11-04 19:29:06 +00:00
Simon Engledew
ff6db59d5a
Fix indentation for action output
...
Co-authored-by: Chris Gavin <chris@chrisgavin.me >
2020-11-04 19:16:09 +00:00
Simon Engledew
77f914a4ba
Add codeql-path to README (wip)
2020-11-04 17:22:32 +00:00
Simon Engledew
c213a7c7c9
Use codeql-path output in python-deps workflow
2020-11-04 17:22:32 +00:00