mirror of
https://github.com/github/codeql-action.git
synced 2025-12-29 18:50:25 +08:00
* Bump the npm group with 12 updates Bumps the npm group with 12 updates: | Package | From | To | | --- | --- | --- | | [@octokit/types](https://github.com/octokit/types.ts) | `12.1.1` | `12.3.0` | | [@types/uuid](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/uuid) | `9.0.6` | `9.0.7` | | [@types/adm-zip](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/adm-zip) | `0.5.3` | `0.5.4` | | [@types/js-yaml](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/js-yaml) | `4.0.8` | `4.0.9` | | [@types/semver](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/semver) | `7.5.4` | `7.5.5` | | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) | `6.9.1` | `6.12.0` | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) | `6.9.1` | `6.12.0` | | [eslint](https://github.com/eslint/eslint) | `8.52.0` | `8.54.0` | | [nock](https://github.com/nock/nock) | `13.3.7` | `13.3.8` | | [sinon](https://github.com/sinonjs/sinon) | `17.0.0` | `17.0.1` | | [@types/sinon](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/sinon) | `10.0.20` | `17.0.1` | | [typescript](https://github.com/Microsoft/TypeScript) | `5.2.2` | `5.3.2` | Updates `@octokit/types` from 12.1.1 to 12.3.0 - [Release notes](https://github.com/octokit/types.ts/releases) - [Commits](https://github.com/octokit/types.ts/compare/v12.1.1...v12.3.0) Updates `@types/uuid` from 9.0.6 to 9.0.7 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/uuid) Updates `@types/adm-zip` from 0.5.3 to 0.5.4 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/adm-zip) Updates `@types/js-yaml` from 4.0.8 to 4.0.9 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/js-yaml) Updates `@types/semver` from 7.5.4 to 7.5.5 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/semver) Updates `@typescript-eslint/eslint-plugin` from 6.9.1 to 6.12.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.12.0/packages/eslint-plugin) Updates `@typescript-eslint/parser` from 6.9.1 to 6.12.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.12.0/packages/parser) Updates `eslint` from 8.52.0 to 8.54.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v8.52.0...v8.54.0) Updates `nock` from 13.3.7 to 13.3.8 - [Release notes](https://github.com/nock/nock/releases) - [Changelog](https://github.com/nock/nock/blob/main/CHANGELOG.md) - [Commits](https://github.com/nock/nock/compare/v13.3.7...v13.3.8) Updates `sinon` from 17.0.0 to 17.0.1 - [Release notes](https://github.com/sinonjs/sinon/releases) - [Changelog](https://github.com/sinonjs/sinon/blob/main/docs/changelog.md) - [Commits](https://github.com/sinonjs/sinon/compare/v17.0.0...v17.0.1) Updates `@types/sinon` from 10.0.20 to 17.0.1 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/sinon) Updates `typescript` from 5.2.2 to 5.3.2 - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](https://github.com/Microsoft/TypeScript/commits) --- updated-dependencies: - dependency-name: "@octokit/types" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: npm - dependency-name: "@types/uuid" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@types/adm-zip" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@types/js-yaml" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@types/semver" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm - dependency-name: nock dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: sinon dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@types/sinon" dependency-type: direct:development update-type: version-update:semver-major dependency-group: npm - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm ... Signed-off-by: dependabot[bot] <support@github.com> * Update checked-in dependencies * Rebuild --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
141 lines
5.0 KiB
JavaScript
141 lines
5.0 KiB
JavaScript
/**
|
|
* @fileoverview enforce "for" loop update clause moving the counter in the right direction.(for-direction)
|
|
* @author Aladdin-ADD<hh_2013@foxmail.com>
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Requirements
|
|
//------------------------------------------------------------------------------
|
|
|
|
const { getStaticValue } = require("@eslint-community/eslint-utils");
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../shared/types').Rule} */
|
|
module.exports = {
|
|
meta: {
|
|
type: "problem",
|
|
|
|
docs: {
|
|
description: "Enforce \"for\" loop update clause moving the counter in the right direction",
|
|
recommended: true,
|
|
url: "https://eslint.org/docs/latest/rules/for-direction"
|
|
},
|
|
|
|
fixable: null,
|
|
schema: [],
|
|
|
|
messages: {
|
|
incorrectDirection: "The update clause in this loop moves the variable in the wrong direction."
|
|
}
|
|
},
|
|
|
|
create(context) {
|
|
const { sourceCode } = context;
|
|
|
|
/**
|
|
* report an error.
|
|
* @param {ASTNode} node the node to report.
|
|
* @returns {void}
|
|
*/
|
|
function report(node) {
|
|
context.report({
|
|
node,
|
|
messageId: "incorrectDirection"
|
|
});
|
|
}
|
|
|
|
/**
|
|
* check the right side of the assignment
|
|
* @param {ASTNode} update UpdateExpression to check
|
|
* @param {int} dir expected direction that could either be turned around or invalidated
|
|
* @returns {int} return dir, the negated dir, or zero if the counter does not change or the direction is not clear
|
|
*/
|
|
function getRightDirection(update, dir) {
|
|
const staticValue = getStaticValue(update.right, sourceCode.getScope(update));
|
|
|
|
if (staticValue && ["bigint", "boolean", "number"].includes(typeof staticValue.value)) {
|
|
const sign = Math.sign(Number(staticValue.value)) || 0; // convert NaN to 0
|
|
|
|
return dir * sign;
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* check UpdateExpression add/sub the counter
|
|
* @param {ASTNode} update UpdateExpression to check
|
|
* @param {string} counter variable name to check
|
|
* @returns {int} if add return 1, if sub return -1, if nochange, return 0
|
|
*/
|
|
function getUpdateDirection(update, counter) {
|
|
if (update.argument.type === "Identifier" && update.argument.name === counter) {
|
|
if (update.operator === "++") {
|
|
return 1;
|
|
}
|
|
if (update.operator === "--") {
|
|
return -1;
|
|
}
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* check AssignmentExpression add/sub the counter
|
|
* @param {ASTNode} update AssignmentExpression to check
|
|
* @param {string} counter variable name to check
|
|
* @returns {int} if add return 1, if sub return -1, if nochange, return 0
|
|
*/
|
|
function getAssignmentDirection(update, counter) {
|
|
if (update.left.name === counter) {
|
|
if (update.operator === "+=") {
|
|
return getRightDirection(update, 1);
|
|
}
|
|
if (update.operator === "-=") {
|
|
return getRightDirection(update, -1);
|
|
}
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
return {
|
|
ForStatement(node) {
|
|
|
|
if (node.test && node.test.type === "BinaryExpression" && node.update) {
|
|
for (const counterPosition of ["left", "right"]) {
|
|
if (node.test[counterPosition].type !== "Identifier") {
|
|
continue;
|
|
}
|
|
|
|
const counter = node.test[counterPosition].name;
|
|
const operator = node.test.operator;
|
|
const update = node.update;
|
|
|
|
let wrongDirection;
|
|
|
|
if (operator === "<" || operator === "<=") {
|
|
wrongDirection = counterPosition === "left" ? -1 : 1;
|
|
} else if (operator === ">" || operator === ">=") {
|
|
wrongDirection = counterPosition === "left" ? 1 : -1;
|
|
} else {
|
|
return;
|
|
}
|
|
|
|
if (update.type === "UpdateExpression") {
|
|
if (getUpdateDirection(update, counter) === wrongDirection) {
|
|
report(node);
|
|
}
|
|
} else if (update.type === "AssignmentExpression" && getAssignmentDirection(update, counter) === wrongDirection) {
|
|
report(node);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
};
|
|
}
|
|
};
|