mirror of
https://github.com/github/codeql-action.git
synced 2025-12-29 18:50:25 +08:00
* Bump the npm group with 12 updates Bumps the npm group with 12 updates: | Package | From | To | | --- | --- | --- | | [@octokit/types](https://github.com/octokit/types.ts) | `12.1.1` | `12.3.0` | | [@types/uuid](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/uuid) | `9.0.6` | `9.0.7` | | [@types/adm-zip](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/adm-zip) | `0.5.3` | `0.5.4` | | [@types/js-yaml](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/js-yaml) | `4.0.8` | `4.0.9` | | [@types/semver](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/semver) | `7.5.4` | `7.5.5` | | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) | `6.9.1` | `6.12.0` | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) | `6.9.1` | `6.12.0` | | [eslint](https://github.com/eslint/eslint) | `8.52.0` | `8.54.0` | | [nock](https://github.com/nock/nock) | `13.3.7` | `13.3.8` | | [sinon](https://github.com/sinonjs/sinon) | `17.0.0` | `17.0.1` | | [@types/sinon](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/sinon) | `10.0.20` | `17.0.1` | | [typescript](https://github.com/Microsoft/TypeScript) | `5.2.2` | `5.3.2` | Updates `@octokit/types` from 12.1.1 to 12.3.0 - [Release notes](https://github.com/octokit/types.ts/releases) - [Commits](https://github.com/octokit/types.ts/compare/v12.1.1...v12.3.0) Updates `@types/uuid` from 9.0.6 to 9.0.7 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/uuid) Updates `@types/adm-zip` from 0.5.3 to 0.5.4 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/adm-zip) Updates `@types/js-yaml` from 4.0.8 to 4.0.9 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/js-yaml) Updates `@types/semver` from 7.5.4 to 7.5.5 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/semver) Updates `@typescript-eslint/eslint-plugin` from 6.9.1 to 6.12.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.12.0/packages/eslint-plugin) Updates `@typescript-eslint/parser` from 6.9.1 to 6.12.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.12.0/packages/parser) Updates `eslint` from 8.52.0 to 8.54.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v8.52.0...v8.54.0) Updates `nock` from 13.3.7 to 13.3.8 - [Release notes](https://github.com/nock/nock/releases) - [Changelog](https://github.com/nock/nock/blob/main/CHANGELOG.md) - [Commits](https://github.com/nock/nock/compare/v13.3.7...v13.3.8) Updates `sinon` from 17.0.0 to 17.0.1 - [Release notes](https://github.com/sinonjs/sinon/releases) - [Changelog](https://github.com/sinonjs/sinon/blob/main/docs/changelog.md) - [Commits](https://github.com/sinonjs/sinon/compare/v17.0.0...v17.0.1) Updates `@types/sinon` from 10.0.20 to 17.0.1 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/sinon) Updates `typescript` from 5.2.2 to 5.3.2 - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](https://github.com/Microsoft/TypeScript/commits) --- updated-dependencies: - dependency-name: "@octokit/types" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: npm - dependency-name: "@types/uuid" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@types/adm-zip" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@types/js-yaml" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@types/semver" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm - dependency-name: nock dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: sinon dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@types/sinon" dependency-type: direct:development update-type: version-update:semver-major dependency-group: npm - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm ... Signed-off-by: dependabot[bot] <support@github.com> * Update checked-in dependencies * Rebuild --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
208 lines
7.2 KiB
JavaScript
208 lines
7.2 KiB
JavaScript
/**
|
|
* @fileoverview Rule to flag use of console object
|
|
* @author Nicholas C. Zakas
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Requirements
|
|
//------------------------------------------------------------------------------
|
|
|
|
const astUtils = require("./utils/ast-utils");
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../shared/types').Rule} */
|
|
module.exports = {
|
|
meta: {
|
|
type: "suggestion",
|
|
|
|
docs: {
|
|
description: "Disallow the use of `console`",
|
|
recommended: false,
|
|
url: "https://eslint.org/docs/latest/rules/no-console"
|
|
},
|
|
|
|
schema: [
|
|
{
|
|
type: "object",
|
|
properties: {
|
|
allow: {
|
|
type: "array",
|
|
items: {
|
|
type: "string"
|
|
},
|
|
minItems: 1,
|
|
uniqueItems: true
|
|
}
|
|
},
|
|
additionalProperties: false
|
|
}
|
|
],
|
|
|
|
hasSuggestions: true,
|
|
|
|
messages: {
|
|
unexpected: "Unexpected console statement.",
|
|
removeConsole: "Remove the console.{{ propertyName }}()."
|
|
}
|
|
},
|
|
|
|
create(context) {
|
|
const options = context.options[0] || {};
|
|
const allowed = options.allow || [];
|
|
const sourceCode = context.sourceCode;
|
|
|
|
/**
|
|
* Checks whether the given reference is 'console' or not.
|
|
* @param {eslint-scope.Reference} reference The reference to check.
|
|
* @returns {boolean} `true` if the reference is 'console'.
|
|
*/
|
|
function isConsole(reference) {
|
|
const id = reference.identifier;
|
|
|
|
return id && id.name === "console";
|
|
}
|
|
|
|
/**
|
|
* Checks whether the property name of the given MemberExpression node
|
|
* is allowed by options or not.
|
|
* @param {ASTNode} node The MemberExpression node to check.
|
|
* @returns {boolean} `true` if the property name of the node is allowed.
|
|
*/
|
|
function isAllowed(node) {
|
|
const propertyName = astUtils.getStaticPropertyName(node);
|
|
|
|
return propertyName && allowed.includes(propertyName);
|
|
}
|
|
|
|
/**
|
|
* Checks whether the given reference is a member access which is not
|
|
* allowed by options or not.
|
|
* @param {eslint-scope.Reference} reference The reference to check.
|
|
* @returns {boolean} `true` if the reference is a member access which
|
|
* is not allowed by options.
|
|
*/
|
|
function isMemberAccessExceptAllowed(reference) {
|
|
const node = reference.identifier;
|
|
const parent = node.parent;
|
|
|
|
return (
|
|
parent.type === "MemberExpression" &&
|
|
parent.object === node &&
|
|
!isAllowed(parent)
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Checks if removing the ExpressionStatement node will cause ASI to
|
|
* break.
|
|
* eg.
|
|
* foo()
|
|
* console.log();
|
|
* [1, 2, 3].forEach(a => doSomething(a))
|
|
*
|
|
* Removing the console.log(); statement should leave two statements, but
|
|
* here the two statements will become one because [ causes continuation after
|
|
* foo().
|
|
* @param {ASTNode} node The ExpressionStatement node to check.
|
|
* @returns {boolean} `true` if ASI will break after removing the ExpressionStatement
|
|
* node.
|
|
*/
|
|
function maybeAsiHazard(node) {
|
|
const SAFE_TOKENS_BEFORE = /^[:;{]$/u; // One of :;{
|
|
const UNSAFE_CHARS_AFTER = /^[-[(/+`]/u; // One of [(/+-`
|
|
|
|
const tokenBefore = sourceCode.getTokenBefore(node);
|
|
const tokenAfter = sourceCode.getTokenAfter(node);
|
|
|
|
return (
|
|
Boolean(tokenAfter) &&
|
|
UNSAFE_CHARS_AFTER.test(tokenAfter.value) &&
|
|
tokenAfter.value !== "++" &&
|
|
tokenAfter.value !== "--" &&
|
|
Boolean(tokenBefore) &&
|
|
!SAFE_TOKENS_BEFORE.test(tokenBefore.value)
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Checks if the MemberExpression node's parent.parent.parent is a
|
|
* Program, BlockStatement, StaticBlock, or SwitchCase node. This check
|
|
* is necessary to avoid providing a suggestion that might cause a syntax error.
|
|
*
|
|
* eg. if (a) console.log(b), removing console.log() here will lead to a
|
|
* syntax error.
|
|
* if (a) { console.log(b) }, removing console.log() here is acceptable.
|
|
*
|
|
* Additionally, it checks if the callee of the CallExpression node is
|
|
* the node itself.
|
|
*
|
|
* eg. foo(console.log), cannot provide a suggestion here.
|
|
* @param {ASTNode} node The MemberExpression node to check.
|
|
* @returns {boolean} `true` if a suggestion can be provided for a node.
|
|
*/
|
|
function canProvideSuggestions(node) {
|
|
return (
|
|
node.parent.type === "CallExpression" &&
|
|
node.parent.callee === node &&
|
|
node.parent.parent.type === "ExpressionStatement" &&
|
|
astUtils.STATEMENT_LIST_PARENTS.has(node.parent.parent.parent.type) &&
|
|
!maybeAsiHazard(node.parent.parent)
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Reports the given reference as a violation.
|
|
* @param {eslint-scope.Reference} reference The reference to report.
|
|
* @returns {void}
|
|
*/
|
|
function report(reference) {
|
|
const node = reference.identifier.parent;
|
|
|
|
const propertyName = astUtils.getStaticPropertyName(node);
|
|
|
|
context.report({
|
|
node,
|
|
loc: node.loc,
|
|
messageId: "unexpected",
|
|
suggest: canProvideSuggestions(node)
|
|
? [{
|
|
messageId: "removeConsole",
|
|
data: { propertyName },
|
|
fix(fixer) {
|
|
return fixer.remove(node.parent.parent);
|
|
}
|
|
}]
|
|
: []
|
|
});
|
|
}
|
|
|
|
return {
|
|
"Program:exit"(node) {
|
|
const scope = sourceCode.getScope(node);
|
|
const consoleVar = astUtils.getVariableByName(scope, "console");
|
|
const shadowed = consoleVar && consoleVar.defs.length > 0;
|
|
|
|
/*
|
|
* 'scope.through' includes all references to undefined
|
|
* variables. If the variable 'console' is not defined, it uses
|
|
* 'scope.through'.
|
|
*/
|
|
const references = consoleVar
|
|
? consoleVar.references
|
|
: scope.through.filter(isConsole);
|
|
|
|
if (!shadowed) {
|
|
references
|
|
.filter(isMemberAccessExceptAllowed)
|
|
.forEach(report);
|
|
}
|
|
}
|
|
};
|
|
}
|
|
};
|