mirror of
https://github.com/github/codeql-action.git
synced 2025-12-27 01:30:10 +08:00
* Bump the npm group with 12 updates Bumps the npm group with 12 updates: | Package | From | To | | --- | --- | --- | | [@octokit/types](https://github.com/octokit/types.ts) | `12.1.1` | `12.3.0` | | [@types/uuid](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/uuid) | `9.0.6` | `9.0.7` | | [@types/adm-zip](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/adm-zip) | `0.5.3` | `0.5.4` | | [@types/js-yaml](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/js-yaml) | `4.0.8` | `4.0.9` | | [@types/semver](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/semver) | `7.5.4` | `7.5.5` | | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) | `6.9.1` | `6.12.0` | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) | `6.9.1` | `6.12.0` | | [eslint](https://github.com/eslint/eslint) | `8.52.0` | `8.54.0` | | [nock](https://github.com/nock/nock) | `13.3.7` | `13.3.8` | | [sinon](https://github.com/sinonjs/sinon) | `17.0.0` | `17.0.1` | | [@types/sinon](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/sinon) | `10.0.20` | `17.0.1` | | [typescript](https://github.com/Microsoft/TypeScript) | `5.2.2` | `5.3.2` | Updates `@octokit/types` from 12.1.1 to 12.3.0 - [Release notes](https://github.com/octokit/types.ts/releases) - [Commits](https://github.com/octokit/types.ts/compare/v12.1.1...v12.3.0) Updates `@types/uuid` from 9.0.6 to 9.0.7 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/uuid) Updates `@types/adm-zip` from 0.5.3 to 0.5.4 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/adm-zip) Updates `@types/js-yaml` from 4.0.8 to 4.0.9 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/js-yaml) Updates `@types/semver` from 7.5.4 to 7.5.5 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/semver) Updates `@typescript-eslint/eslint-plugin` from 6.9.1 to 6.12.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.12.0/packages/eslint-plugin) Updates `@typescript-eslint/parser` from 6.9.1 to 6.12.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.12.0/packages/parser) Updates `eslint` from 8.52.0 to 8.54.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v8.52.0...v8.54.0) Updates `nock` from 13.3.7 to 13.3.8 - [Release notes](https://github.com/nock/nock/releases) - [Changelog](https://github.com/nock/nock/blob/main/CHANGELOG.md) - [Commits](https://github.com/nock/nock/compare/v13.3.7...v13.3.8) Updates `sinon` from 17.0.0 to 17.0.1 - [Release notes](https://github.com/sinonjs/sinon/releases) - [Changelog](https://github.com/sinonjs/sinon/blob/main/docs/changelog.md) - [Commits](https://github.com/sinonjs/sinon/compare/v17.0.0...v17.0.1) Updates `@types/sinon` from 10.0.20 to 17.0.1 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/sinon) Updates `typescript` from 5.2.2 to 5.3.2 - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](https://github.com/Microsoft/TypeScript/commits) --- updated-dependencies: - dependency-name: "@octokit/types" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: npm - dependency-name: "@types/uuid" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@types/adm-zip" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@types/js-yaml" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@types/semver" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm - dependency-name: nock dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: sinon dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@types/sinon" dependency-type: direct:development update-type: version-update:semver-major dependency-group: npm - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm ... Signed-off-by: dependabot[bot] <support@github.com> * Update checked-in dependencies * Rebuild --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
168 lines
5.9 KiB
JavaScript
168 lines
5.9 KiB
JavaScript
/**
|
|
* @fileoverview Rule to validate spacing before function paren.
|
|
* @author Mathias Schreck <https://github.com/lo1tuma>
|
|
* @deprecated in ESLint v8.53.0
|
|
*/
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Requirements
|
|
//------------------------------------------------------------------------------
|
|
|
|
const astUtils = require("./utils/ast-utils");
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../shared/types').Rule} */
|
|
module.exports = {
|
|
meta: {
|
|
deprecated: true,
|
|
replacedBy: [],
|
|
type: "layout",
|
|
|
|
docs: {
|
|
description: "Enforce consistent spacing before `function` definition opening parenthesis",
|
|
recommended: false,
|
|
url: "https://eslint.org/docs/latest/rules/space-before-function-paren"
|
|
},
|
|
|
|
fixable: "whitespace",
|
|
|
|
schema: [
|
|
{
|
|
oneOf: [
|
|
{
|
|
enum: ["always", "never"]
|
|
},
|
|
{
|
|
type: "object",
|
|
properties: {
|
|
anonymous: {
|
|
enum: ["always", "never", "ignore"]
|
|
},
|
|
named: {
|
|
enum: ["always", "never", "ignore"]
|
|
},
|
|
asyncArrow: {
|
|
enum: ["always", "never", "ignore"]
|
|
}
|
|
},
|
|
additionalProperties: false
|
|
}
|
|
]
|
|
}
|
|
],
|
|
|
|
messages: {
|
|
unexpectedSpace: "Unexpected space before function parentheses.",
|
|
missingSpace: "Missing space before function parentheses."
|
|
}
|
|
},
|
|
|
|
create(context) {
|
|
const sourceCode = context.sourceCode;
|
|
const baseConfig = typeof context.options[0] === "string" ? context.options[0] : "always";
|
|
const overrideConfig = typeof context.options[0] === "object" ? context.options[0] : {};
|
|
|
|
/**
|
|
* Determines whether a function has a name.
|
|
* @param {ASTNode} node The function node.
|
|
* @returns {boolean} Whether the function has a name.
|
|
*/
|
|
function isNamedFunction(node) {
|
|
if (node.id) {
|
|
return true;
|
|
}
|
|
|
|
const parent = node.parent;
|
|
|
|
return parent.type === "MethodDefinition" ||
|
|
(parent.type === "Property" &&
|
|
(
|
|
parent.kind === "get" ||
|
|
parent.kind === "set" ||
|
|
parent.method
|
|
)
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Gets the config for a given function
|
|
* @param {ASTNode} node The function node
|
|
* @returns {string} "always", "never", or "ignore"
|
|
*/
|
|
function getConfigForFunction(node) {
|
|
if (node.type === "ArrowFunctionExpression") {
|
|
|
|
// Always ignore non-async functions and arrow functions without parens, e.g. async foo => bar
|
|
if (node.async && astUtils.isOpeningParenToken(sourceCode.getFirstToken(node, { skip: 1 }))) {
|
|
return overrideConfig.asyncArrow || baseConfig;
|
|
}
|
|
} else if (isNamedFunction(node)) {
|
|
return overrideConfig.named || baseConfig;
|
|
|
|
// `generator-star-spacing` should warn anonymous generators. E.g. `function* () {}`
|
|
} else if (!node.generator) {
|
|
return overrideConfig.anonymous || baseConfig;
|
|
}
|
|
|
|
return "ignore";
|
|
}
|
|
|
|
/**
|
|
* Checks the parens of a function node
|
|
* @param {ASTNode} node A function node
|
|
* @returns {void}
|
|
*/
|
|
function checkFunction(node) {
|
|
const functionConfig = getConfigForFunction(node);
|
|
|
|
if (functionConfig === "ignore") {
|
|
return;
|
|
}
|
|
|
|
const rightToken = sourceCode.getFirstToken(node, astUtils.isOpeningParenToken);
|
|
const leftToken = sourceCode.getTokenBefore(rightToken);
|
|
const hasSpacing = sourceCode.isSpaceBetweenTokens(leftToken, rightToken);
|
|
|
|
if (hasSpacing && functionConfig === "never") {
|
|
context.report({
|
|
node,
|
|
loc: {
|
|
start: leftToken.loc.end,
|
|
end: rightToken.loc.start
|
|
},
|
|
messageId: "unexpectedSpace",
|
|
fix(fixer) {
|
|
const comments = sourceCode.getCommentsBefore(rightToken);
|
|
|
|
// Don't fix anything if there's a single line comment between the left and the right token
|
|
if (comments.some(comment => comment.type === "Line")) {
|
|
return null;
|
|
}
|
|
return fixer.replaceTextRange(
|
|
[leftToken.range[1], rightToken.range[0]],
|
|
comments.reduce((text, comment) => text + sourceCode.getText(comment), "")
|
|
);
|
|
}
|
|
});
|
|
} else if (!hasSpacing && functionConfig === "always") {
|
|
context.report({
|
|
node,
|
|
loc: rightToken.loc,
|
|
messageId: "missingSpace",
|
|
fix: fixer => fixer.insertTextAfter(leftToken, " ")
|
|
});
|
|
}
|
|
}
|
|
|
|
return {
|
|
ArrowFunctionExpression: checkFunction,
|
|
FunctionDeclaration: checkFunction,
|
|
FunctionExpression: checkFunction
|
|
};
|
|
}
|
|
};
|