mirror of
https://github.com/github/codeql-action.git
synced 2025-12-22 07:10:23 +08:00
86 lines
2.8 KiB
JavaScript
86 lines
2.8 KiB
JavaScript
const {getProp, getLiteralPropValue} = require('jsx-ast-utils')
|
|
const {getElementType} = require('../utils/get-element-type')
|
|
const {generateObjSchema} = require('eslint-plugin-jsx-a11y/lib/util/schemas')
|
|
|
|
const defaultClassName = 'sr-only'
|
|
const defaultcomponentName = 'VisuallyHidden'
|
|
|
|
const schema = generateObjSchema({
|
|
className: {type: 'string'},
|
|
componentName: {type: 'string'},
|
|
})
|
|
|
|
/** Note: we are not including input elements at this time
|
|
* because a visually hidden input field might cause a false positive.
|
|
* (e.g. fileUpload https://github.com/primer/react/pull/3492)
|
|
*/
|
|
const INTERACTIVE_ELEMENTS = ['a', 'button', 'summary', 'select', 'option', 'textarea']
|
|
|
|
const checkIfInteractiveElement = (context, node) => {
|
|
const elementType = getElementType(context, node.openingElement)
|
|
|
|
for (const interactiveElement of INTERACTIVE_ELEMENTS) {
|
|
if (elementType === interactiveElement) {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
// if the node is visually hidden recursively check if it has interactive children
|
|
const checkIfVisuallyHiddenAndInteractive = (context, options, node, isParentVisuallyHidden) => {
|
|
const {className, componentName} = options
|
|
if (node.type === 'JSXElement') {
|
|
const classes = getLiteralPropValue(getProp(node.openingElement.attributes, 'className'))
|
|
const isVisuallyHiddenElement = node.openingElement.name.name === componentName
|
|
let hasSROnlyClass = false
|
|
if (classes != null) {
|
|
hasSROnlyClass = classes.includes(className)
|
|
}
|
|
let isHidden = false
|
|
if (hasSROnlyClass || isVisuallyHiddenElement || !!isParentVisuallyHidden) {
|
|
if (checkIfInteractiveElement(context, node)) {
|
|
return true
|
|
}
|
|
isHidden = true
|
|
}
|
|
if (node.children && node.children.length > 0) {
|
|
return (
|
|
typeof node.children?.find(child =>
|
|
checkIfVisuallyHiddenAndInteractive(context, options, child, !!isParentVisuallyHidden || isHidden),
|
|
) !== 'undefined'
|
|
)
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
module.exports = {
|
|
meta: {
|
|
docs: {
|
|
description: 'Ensures that interactive elements are not visually hidden',
|
|
url: require('../url')(module),
|
|
},
|
|
schema: [schema],
|
|
},
|
|
|
|
create(context) {
|
|
const {options} = context
|
|
const config = options[0] || {}
|
|
const className = config.className || defaultClassName
|
|
const componentName = config.componentName || defaultcomponentName
|
|
|
|
return {
|
|
JSXElement: node => {
|
|
if (checkIfVisuallyHiddenAndInteractive(context, {className, componentName}, node, false)) {
|
|
context.report({
|
|
node,
|
|
message:
|
|
'Avoid visually hidding interactive elements. Visually hiding interactive elements can be confusing to sighted keyboard users as it appears their focus has been lost when they navigate to the hidden element.',
|
|
})
|
|
}
|
|
},
|
|
}
|
|
},
|
|
}
|