mirror of
https://github.com/github/codeql-action.git
synced 2026-01-04 21:50:17 +08:00
* Bump the npm group with 11 updates Bumps the npm group with 11 updates: | Package | From | To | | --- | --- | --- | | [@actions/artifact](https://github.com/actions/toolkit/tree/HEAD/packages/artifact) | `1.1.1` | `1.1.2` | | [@actions/core](https://github.com/actions/toolkit/tree/HEAD/packages/core) | `1.10.0` | `1.10.1` | | [uuid](https://github.com/uuidjs/uuid) | `9.0.0` | `9.0.1` | | [@types/uuid](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/uuid) | `9.0.3` | `9.0.4` | | [@types/adm-zip](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/adm-zip) | `0.5.0` | `0.5.1` | | [@types/js-yaml](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/js-yaml) | `4.0.5` | `4.0.6` | | [@types/semver](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/semver) | `7.5.1` | `7.5.2` | | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) | `6.5.0` | `6.7.2` | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) | `6.6.0` | `6.7.2` | | [eslint](https://github.com/eslint/eslint) | `8.48.0` | `8.49.0` | | [sinon](https://github.com/sinonjs/sinon) | `15.2.0` | `16.0.0` | Updates `@actions/artifact` from 1.1.1 to 1.1.2 - [Changelog](https://github.com/actions/toolkit/blob/main/packages/artifact/RELEASES.md) - [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/artifact) Updates `@actions/core` from 1.10.0 to 1.10.1 - [Changelog](https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md) - [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/core) Updates `uuid` from 9.0.0 to 9.0.1 - [Changelog](https://github.com/uuidjs/uuid/blob/main/CHANGELOG.md) - [Commits](https://github.com/uuidjs/uuid/compare/v9.0.0...v9.0.1) Updates `@types/uuid` from 9.0.3 to 9.0.4 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/uuid) Updates `@types/adm-zip` from 0.5.0 to 0.5.1 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/adm-zip) Updates `@types/js-yaml` from 4.0.5 to 4.0.6 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/js-yaml) Updates `@types/semver` from 7.5.1 to 7.5.2 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/semver) Updates `@typescript-eslint/eslint-plugin` from 6.5.0 to 6.7.2 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.7.2/packages/eslint-plugin) Updates `@typescript-eslint/parser` from 6.6.0 to 6.7.2 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.7.2/packages/parser) Updates `eslint` from 8.48.0 to 8.49.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v8.48.0...v8.49.0) Updates `sinon` from 15.2.0 to 16.0.0 - [Release notes](https://github.com/sinonjs/sinon/releases) - [Changelog](https://github.com/sinonjs/sinon/blob/main/docs/changelog.md) - [Commits](https://github.com/sinonjs/sinon/compare/v15.2.0...v16.0.0) --- updated-dependencies: - dependency-name: "@actions/artifact" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@actions/core" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: npm - dependency-name: uuid dependency-type: direct:production update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@types/uuid" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@types/adm-zip" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@types/js-yaml" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@types/semver" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm - dependency-name: sinon dependency-type: direct:development update-type: version-update:semver-major dependency-group: npm ... Signed-off-by: dependabot[bot] <support@github.com> * Update checked-in dependencies --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
332 lines
11 KiB
JavaScript
332 lines
11 KiB
JavaScript
/**
|
|
* @fileoverview A rule to disallow using `this`/`super` before `super()`.
|
|
* @author Toru Nagashima
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Requirements
|
|
//------------------------------------------------------------------------------
|
|
|
|
const astUtils = require("./utils/ast-utils");
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Helpers
|
|
//------------------------------------------------------------------------------
|
|
|
|
/**
|
|
* Checks whether or not a given node is a constructor.
|
|
* @param {ASTNode} node A node to check. This node type is one of
|
|
* `Program`, `FunctionDeclaration`, `FunctionExpression`, and
|
|
* `ArrowFunctionExpression`.
|
|
* @returns {boolean} `true` if the node is a constructor.
|
|
*/
|
|
function isConstructorFunction(node) {
|
|
return (
|
|
node.type === "FunctionExpression" &&
|
|
node.parent.type === "MethodDefinition" &&
|
|
node.parent.kind === "constructor"
|
|
);
|
|
}
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../shared/types').Rule} */
|
|
module.exports = {
|
|
meta: {
|
|
type: "problem",
|
|
|
|
docs: {
|
|
description: "Disallow `this`/`super` before calling `super()` in constructors",
|
|
recommended: true,
|
|
url: "https://eslint.org/docs/latest/rules/no-this-before-super"
|
|
},
|
|
|
|
schema: [],
|
|
|
|
messages: {
|
|
noBeforeSuper: "'{{kind}}' is not allowed before 'super()'."
|
|
}
|
|
},
|
|
|
|
create(context) {
|
|
|
|
/*
|
|
* Information for each constructor.
|
|
* - upper: Information of the upper constructor.
|
|
* - hasExtends: A flag which shows whether the owner class has a valid
|
|
* `extends` part.
|
|
* - scope: The scope of the owner class.
|
|
* - codePath: The code path of this constructor.
|
|
*/
|
|
let funcInfo = null;
|
|
|
|
/*
|
|
* Information for each code path segment.
|
|
* Each key is the id of a code path segment.
|
|
* Each value is an object:
|
|
* - superCalled: The flag which shows `super()` called in all code paths.
|
|
* - invalidNodes: The array of invalid ThisExpression and Super nodes.
|
|
*/
|
|
let segInfoMap = Object.create(null);
|
|
|
|
/**
|
|
* Gets whether or not `super()` is called in a given code path segment.
|
|
* @param {CodePathSegment} segment A code path segment to get.
|
|
* @returns {boolean} `true` if `super()` is called.
|
|
*/
|
|
function isCalled(segment) {
|
|
return !segment.reachable || segInfoMap[segment.id].superCalled;
|
|
}
|
|
|
|
/**
|
|
* Checks whether or not this is in a constructor.
|
|
* @returns {boolean} `true` if this is in a constructor.
|
|
*/
|
|
function isInConstructorOfDerivedClass() {
|
|
return Boolean(funcInfo && funcInfo.isConstructor && funcInfo.hasExtends);
|
|
}
|
|
|
|
/**
|
|
* Determines if every segment in a set has been called.
|
|
* @param {Set<CodePathSegment>} segments The segments to search.
|
|
* @returns {boolean} True if every segment has been called; false otherwise.
|
|
*/
|
|
function isEverySegmentCalled(segments) {
|
|
for (const segment of segments) {
|
|
if (!isCalled(segment)) {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
/**
|
|
* Checks whether or not this is before `super()` is called.
|
|
* @returns {boolean} `true` if this is before `super()` is called.
|
|
*/
|
|
function isBeforeCallOfSuper() {
|
|
return (
|
|
isInConstructorOfDerivedClass() &&
|
|
!isEverySegmentCalled(funcInfo.currentSegments)
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Sets a given node as invalid.
|
|
* @param {ASTNode} node A node to set as invalid. This is one of
|
|
* a ThisExpression and a Super.
|
|
* @returns {void}
|
|
*/
|
|
function setInvalid(node) {
|
|
const segments = funcInfo.currentSegments;
|
|
|
|
for (const segment of segments) {
|
|
if (segment.reachable) {
|
|
segInfoMap[segment.id].invalidNodes.push(node);
|
|
}
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Sets the current segment as `super` was called.
|
|
* @returns {void}
|
|
*/
|
|
function setSuperCalled() {
|
|
const segments = funcInfo.currentSegments;
|
|
|
|
for (const segment of segments) {
|
|
if (segment.reachable) {
|
|
segInfoMap[segment.id].superCalled = true;
|
|
}
|
|
}
|
|
}
|
|
|
|
return {
|
|
|
|
/**
|
|
* Adds information of a constructor into the stack.
|
|
* @param {CodePath} codePath A code path which was started.
|
|
* @param {ASTNode} node The current node.
|
|
* @returns {void}
|
|
*/
|
|
onCodePathStart(codePath, node) {
|
|
if (isConstructorFunction(node)) {
|
|
|
|
// Class > ClassBody > MethodDefinition > FunctionExpression
|
|
const classNode = node.parent.parent.parent;
|
|
|
|
funcInfo = {
|
|
upper: funcInfo,
|
|
isConstructor: true,
|
|
hasExtends: Boolean(
|
|
classNode.superClass &&
|
|
!astUtils.isNullOrUndefined(classNode.superClass)
|
|
),
|
|
codePath,
|
|
currentSegments: new Set()
|
|
};
|
|
} else {
|
|
funcInfo = {
|
|
upper: funcInfo,
|
|
isConstructor: false,
|
|
hasExtends: false,
|
|
codePath,
|
|
currentSegments: new Set()
|
|
};
|
|
}
|
|
},
|
|
|
|
/**
|
|
* Removes the top of stack item.
|
|
*
|
|
* And this traverses all segments of this code path then reports every
|
|
* invalid node.
|
|
* @param {CodePath} codePath A code path which was ended.
|
|
* @returns {void}
|
|
*/
|
|
onCodePathEnd(codePath) {
|
|
const isDerivedClass = funcInfo.hasExtends;
|
|
|
|
funcInfo = funcInfo.upper;
|
|
if (!isDerivedClass) {
|
|
return;
|
|
}
|
|
|
|
codePath.traverseSegments((segment, controller) => {
|
|
const info = segInfoMap[segment.id];
|
|
|
|
for (let i = 0; i < info.invalidNodes.length; ++i) {
|
|
const invalidNode = info.invalidNodes[i];
|
|
|
|
context.report({
|
|
messageId: "noBeforeSuper",
|
|
node: invalidNode,
|
|
data: {
|
|
kind: invalidNode.type === "Super" ? "super" : "this"
|
|
}
|
|
});
|
|
}
|
|
|
|
if (info.superCalled) {
|
|
controller.skip();
|
|
}
|
|
});
|
|
},
|
|
|
|
/**
|
|
* Initialize information of a given code path segment.
|
|
* @param {CodePathSegment} segment A code path segment to initialize.
|
|
* @returns {void}
|
|
*/
|
|
onCodePathSegmentStart(segment) {
|
|
funcInfo.currentSegments.add(segment);
|
|
|
|
if (!isInConstructorOfDerivedClass()) {
|
|
return;
|
|
}
|
|
|
|
// Initialize info.
|
|
segInfoMap[segment.id] = {
|
|
superCalled: (
|
|
segment.prevSegments.length > 0 &&
|
|
segment.prevSegments.every(isCalled)
|
|
),
|
|
invalidNodes: []
|
|
};
|
|
},
|
|
|
|
onUnreachableCodePathSegmentStart(segment) {
|
|
funcInfo.currentSegments.add(segment);
|
|
},
|
|
|
|
onUnreachableCodePathSegmentEnd(segment) {
|
|
funcInfo.currentSegments.delete(segment);
|
|
},
|
|
|
|
onCodePathSegmentEnd(segment) {
|
|
funcInfo.currentSegments.delete(segment);
|
|
},
|
|
|
|
/**
|
|
* Update information of the code path segment when a code path was
|
|
* looped.
|
|
* @param {CodePathSegment} fromSegment The code path segment of the
|
|
* end of a loop.
|
|
* @param {CodePathSegment} toSegment A code path segment of the head
|
|
* of a loop.
|
|
* @returns {void}
|
|
*/
|
|
onCodePathSegmentLoop(fromSegment, toSegment) {
|
|
if (!isInConstructorOfDerivedClass()) {
|
|
return;
|
|
}
|
|
|
|
// Update information inside of the loop.
|
|
funcInfo.codePath.traverseSegments(
|
|
{ first: toSegment, last: fromSegment },
|
|
(segment, controller) => {
|
|
const info = segInfoMap[segment.id];
|
|
|
|
if (info.superCalled) {
|
|
info.invalidNodes = [];
|
|
controller.skip();
|
|
} else if (
|
|
segment.prevSegments.length > 0 &&
|
|
segment.prevSegments.every(isCalled)
|
|
) {
|
|
info.superCalled = true;
|
|
info.invalidNodes = [];
|
|
}
|
|
}
|
|
);
|
|
},
|
|
|
|
/**
|
|
* Reports if this is before `super()`.
|
|
* @param {ASTNode} node A target node.
|
|
* @returns {void}
|
|
*/
|
|
ThisExpression(node) {
|
|
if (isBeforeCallOfSuper()) {
|
|
setInvalid(node);
|
|
}
|
|
},
|
|
|
|
/**
|
|
* Reports if this is before `super()`.
|
|
* @param {ASTNode} node A target node.
|
|
* @returns {void}
|
|
*/
|
|
Super(node) {
|
|
if (!astUtils.isCallee(node) && isBeforeCallOfSuper()) {
|
|
setInvalid(node);
|
|
}
|
|
},
|
|
|
|
/**
|
|
* Marks `super()` called.
|
|
* @param {ASTNode} node A target node.
|
|
* @returns {void}
|
|
*/
|
|
"CallExpression:exit"(node) {
|
|
if (node.callee.type === "Super" && isBeforeCallOfSuper()) {
|
|
setSuperCalled();
|
|
}
|
|
},
|
|
|
|
/**
|
|
* Resets state.
|
|
* @returns {void}
|
|
*/
|
|
"Program:exit"() {
|
|
segInfoMap = Object.create(null);
|
|
}
|
|
};
|
|
}
|
|
};
|