mirror of
https://github.com/github/codeql-action.git
synced 2025-12-30 19:20:08 +08:00
* Bump the npm group with 12 updates Bumps the npm group with 12 updates: | Package | From | To | | --- | --- | --- | | [@octokit/types](https://github.com/octokit/types.ts) | `12.1.1` | `12.3.0` | | [@types/uuid](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/uuid) | `9.0.6` | `9.0.7` | | [@types/adm-zip](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/adm-zip) | `0.5.3` | `0.5.4` | | [@types/js-yaml](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/js-yaml) | `4.0.8` | `4.0.9` | | [@types/semver](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/semver) | `7.5.4` | `7.5.5` | | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) | `6.9.1` | `6.12.0` | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) | `6.9.1` | `6.12.0` | | [eslint](https://github.com/eslint/eslint) | `8.52.0` | `8.54.0` | | [nock](https://github.com/nock/nock) | `13.3.7` | `13.3.8` | | [sinon](https://github.com/sinonjs/sinon) | `17.0.0` | `17.0.1` | | [@types/sinon](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/sinon) | `10.0.20` | `17.0.1` | | [typescript](https://github.com/Microsoft/TypeScript) | `5.2.2` | `5.3.2` | Updates `@octokit/types` from 12.1.1 to 12.3.0 - [Release notes](https://github.com/octokit/types.ts/releases) - [Commits](https://github.com/octokit/types.ts/compare/v12.1.1...v12.3.0) Updates `@types/uuid` from 9.0.6 to 9.0.7 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/uuid) Updates `@types/adm-zip` from 0.5.3 to 0.5.4 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/adm-zip) Updates `@types/js-yaml` from 4.0.8 to 4.0.9 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/js-yaml) Updates `@types/semver` from 7.5.4 to 7.5.5 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/semver) Updates `@typescript-eslint/eslint-plugin` from 6.9.1 to 6.12.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.12.0/packages/eslint-plugin) Updates `@typescript-eslint/parser` from 6.9.1 to 6.12.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.12.0/packages/parser) Updates `eslint` from 8.52.0 to 8.54.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v8.52.0...v8.54.0) Updates `nock` from 13.3.7 to 13.3.8 - [Release notes](https://github.com/nock/nock/releases) - [Changelog](https://github.com/nock/nock/blob/main/CHANGELOG.md) - [Commits](https://github.com/nock/nock/compare/v13.3.7...v13.3.8) Updates `sinon` from 17.0.0 to 17.0.1 - [Release notes](https://github.com/sinonjs/sinon/releases) - [Changelog](https://github.com/sinonjs/sinon/blob/main/docs/changelog.md) - [Commits](https://github.com/sinonjs/sinon/compare/v17.0.0...v17.0.1) Updates `@types/sinon` from 10.0.20 to 17.0.1 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/sinon) Updates `typescript` from 5.2.2 to 5.3.2 - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](https://github.com/Microsoft/TypeScript/commits) --- updated-dependencies: - dependency-name: "@octokit/types" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: npm - dependency-name: "@types/uuid" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@types/adm-zip" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@types/js-yaml" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@types/semver" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm - dependency-name: nock dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: sinon dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@types/sinon" dependency-type: direct:development update-type: version-update:semver-major dependency-group: npm - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm ... Signed-off-by: dependabot[bot] <support@github.com> * Update checked-in dependencies * Rebuild --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
249 lines
8.7 KiB
JavaScript
249 lines
8.7 KiB
JavaScript
/**
|
|
* @fileoverview Validates spacing before and after semicolon
|
|
* @author Mathias Schreck
|
|
* @deprecated in ESLint v8.53.0
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
const astUtils = require("./utils/ast-utils");
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../shared/types').Rule} */
|
|
module.exports = {
|
|
meta: {
|
|
deprecated: true,
|
|
replacedBy: [],
|
|
type: "layout",
|
|
|
|
docs: {
|
|
description: "Enforce consistent spacing before and after semicolons",
|
|
recommended: false,
|
|
url: "https://eslint.org/docs/latest/rules/semi-spacing"
|
|
},
|
|
|
|
fixable: "whitespace",
|
|
|
|
schema: [
|
|
{
|
|
type: "object",
|
|
properties: {
|
|
before: {
|
|
type: "boolean",
|
|
default: false
|
|
},
|
|
after: {
|
|
type: "boolean",
|
|
default: true
|
|
}
|
|
},
|
|
additionalProperties: false
|
|
}
|
|
],
|
|
|
|
messages: {
|
|
unexpectedWhitespaceBefore: "Unexpected whitespace before semicolon.",
|
|
unexpectedWhitespaceAfter: "Unexpected whitespace after semicolon.",
|
|
missingWhitespaceBefore: "Missing whitespace before semicolon.",
|
|
missingWhitespaceAfter: "Missing whitespace after semicolon."
|
|
}
|
|
},
|
|
|
|
create(context) {
|
|
|
|
const config = context.options[0],
|
|
sourceCode = context.sourceCode;
|
|
let requireSpaceBefore = false,
|
|
requireSpaceAfter = true;
|
|
|
|
if (typeof config === "object") {
|
|
requireSpaceBefore = config.before;
|
|
requireSpaceAfter = config.after;
|
|
}
|
|
|
|
/**
|
|
* Checks if a given token has leading whitespace.
|
|
* @param {Object} token The token to check.
|
|
* @returns {boolean} True if the given token has leading space, false if not.
|
|
*/
|
|
function hasLeadingSpace(token) {
|
|
const tokenBefore = sourceCode.getTokenBefore(token);
|
|
|
|
return tokenBefore && astUtils.isTokenOnSameLine(tokenBefore, token) && sourceCode.isSpaceBetweenTokens(tokenBefore, token);
|
|
}
|
|
|
|
/**
|
|
* Checks if a given token has trailing whitespace.
|
|
* @param {Object} token The token to check.
|
|
* @returns {boolean} True if the given token has trailing space, false if not.
|
|
*/
|
|
function hasTrailingSpace(token) {
|
|
const tokenAfter = sourceCode.getTokenAfter(token);
|
|
|
|
return tokenAfter && astUtils.isTokenOnSameLine(token, tokenAfter) && sourceCode.isSpaceBetweenTokens(token, tokenAfter);
|
|
}
|
|
|
|
/**
|
|
* Checks if the given token is the last token in its line.
|
|
* @param {Token} token The token to check.
|
|
* @returns {boolean} Whether or not the token is the last in its line.
|
|
*/
|
|
function isLastTokenInCurrentLine(token) {
|
|
const tokenAfter = sourceCode.getTokenAfter(token);
|
|
|
|
return !(tokenAfter && astUtils.isTokenOnSameLine(token, tokenAfter));
|
|
}
|
|
|
|
/**
|
|
* Checks if the given token is the first token in its line
|
|
* @param {Token} token The token to check.
|
|
* @returns {boolean} Whether or not the token is the first in its line.
|
|
*/
|
|
function isFirstTokenInCurrentLine(token) {
|
|
const tokenBefore = sourceCode.getTokenBefore(token);
|
|
|
|
return !(tokenBefore && astUtils.isTokenOnSameLine(token, tokenBefore));
|
|
}
|
|
|
|
/**
|
|
* Checks if the next token of a given token is a closing parenthesis.
|
|
* @param {Token} token The token to check.
|
|
* @returns {boolean} Whether or not the next token of a given token is a closing parenthesis.
|
|
*/
|
|
function isBeforeClosingParen(token) {
|
|
const nextToken = sourceCode.getTokenAfter(token);
|
|
|
|
return (nextToken && astUtils.isClosingBraceToken(nextToken) || astUtils.isClosingParenToken(nextToken));
|
|
}
|
|
|
|
/**
|
|
* Report location example :
|
|
*
|
|
* for unexpected space `before`
|
|
*
|
|
* var a = 'b' ;
|
|
* ^^^
|
|
*
|
|
* for unexpected space `after`
|
|
*
|
|
* var a = 'b'; c = 10;
|
|
* ^^
|
|
*
|
|
* Reports if the given token has invalid spacing.
|
|
* @param {Token} token The semicolon token to check.
|
|
* @param {ASTNode} node The corresponding node of the token.
|
|
* @returns {void}
|
|
*/
|
|
function checkSemicolonSpacing(token, node) {
|
|
if (astUtils.isSemicolonToken(token)) {
|
|
if (hasLeadingSpace(token)) {
|
|
if (!requireSpaceBefore) {
|
|
const tokenBefore = sourceCode.getTokenBefore(token);
|
|
const loc = {
|
|
start: tokenBefore.loc.end,
|
|
end: token.loc.start
|
|
};
|
|
|
|
context.report({
|
|
node,
|
|
loc,
|
|
messageId: "unexpectedWhitespaceBefore",
|
|
fix(fixer) {
|
|
|
|
return fixer.removeRange([tokenBefore.range[1], token.range[0]]);
|
|
}
|
|
});
|
|
}
|
|
} else {
|
|
if (requireSpaceBefore) {
|
|
const loc = token.loc;
|
|
|
|
context.report({
|
|
node,
|
|
loc,
|
|
messageId: "missingWhitespaceBefore",
|
|
fix(fixer) {
|
|
return fixer.insertTextBefore(token, " ");
|
|
}
|
|
});
|
|
}
|
|
}
|
|
|
|
if (!isFirstTokenInCurrentLine(token) && !isLastTokenInCurrentLine(token) && !isBeforeClosingParen(token)) {
|
|
if (hasTrailingSpace(token)) {
|
|
if (!requireSpaceAfter) {
|
|
const tokenAfter = sourceCode.getTokenAfter(token);
|
|
const loc = {
|
|
start: token.loc.end,
|
|
end: tokenAfter.loc.start
|
|
};
|
|
|
|
context.report({
|
|
node,
|
|
loc,
|
|
messageId: "unexpectedWhitespaceAfter",
|
|
fix(fixer) {
|
|
|
|
return fixer.removeRange([token.range[1], tokenAfter.range[0]]);
|
|
}
|
|
});
|
|
}
|
|
} else {
|
|
if (requireSpaceAfter) {
|
|
const loc = token.loc;
|
|
|
|
context.report({
|
|
node,
|
|
loc,
|
|
messageId: "missingWhitespaceAfter",
|
|
fix(fixer) {
|
|
return fixer.insertTextAfter(token, " ");
|
|
}
|
|
});
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Checks the spacing of the semicolon with the assumption that the last token is the semicolon.
|
|
* @param {ASTNode} node The node to check.
|
|
* @returns {void}
|
|
*/
|
|
function checkNode(node) {
|
|
const token = sourceCode.getLastToken(node);
|
|
|
|
checkSemicolonSpacing(token, node);
|
|
}
|
|
|
|
return {
|
|
VariableDeclaration: checkNode,
|
|
ExpressionStatement: checkNode,
|
|
BreakStatement: checkNode,
|
|
ContinueStatement: checkNode,
|
|
DebuggerStatement: checkNode,
|
|
DoWhileStatement: checkNode,
|
|
ReturnStatement: checkNode,
|
|
ThrowStatement: checkNode,
|
|
ImportDeclaration: checkNode,
|
|
ExportNamedDeclaration: checkNode,
|
|
ExportAllDeclaration: checkNode,
|
|
ExportDefaultDeclaration: checkNode,
|
|
ForStatement(node) {
|
|
if (node.init) {
|
|
checkSemicolonSpacing(sourceCode.getTokenAfter(node.init), node);
|
|
}
|
|
|
|
if (node.test) {
|
|
checkSemicolonSpacing(sourceCode.getTokenAfter(node.test), node);
|
|
}
|
|
},
|
|
PropertyDefinition: checkNode
|
|
};
|
|
}
|
|
};
|