mirror of
https://github.com/github/codeql-action.git
synced 2026-01-04 21:50:17 +08:00
* Bump the npm group with 12 updates Bumps the npm group with 12 updates: | Package | From | To | | --- | --- | --- | | [@octokit/types](https://github.com/octokit/types.ts) | `12.1.1` | `12.3.0` | | [@types/uuid](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/uuid) | `9.0.6` | `9.0.7` | | [@types/adm-zip](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/adm-zip) | `0.5.3` | `0.5.4` | | [@types/js-yaml](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/js-yaml) | `4.0.8` | `4.0.9` | | [@types/semver](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/semver) | `7.5.4` | `7.5.5` | | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) | `6.9.1` | `6.12.0` | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) | `6.9.1` | `6.12.0` | | [eslint](https://github.com/eslint/eslint) | `8.52.0` | `8.54.0` | | [nock](https://github.com/nock/nock) | `13.3.7` | `13.3.8` | | [sinon](https://github.com/sinonjs/sinon) | `17.0.0` | `17.0.1` | | [@types/sinon](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/sinon) | `10.0.20` | `17.0.1` | | [typescript](https://github.com/Microsoft/TypeScript) | `5.2.2` | `5.3.2` | Updates `@octokit/types` from 12.1.1 to 12.3.0 - [Release notes](https://github.com/octokit/types.ts/releases) - [Commits](https://github.com/octokit/types.ts/compare/v12.1.1...v12.3.0) Updates `@types/uuid` from 9.0.6 to 9.0.7 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/uuid) Updates `@types/adm-zip` from 0.5.3 to 0.5.4 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/adm-zip) Updates `@types/js-yaml` from 4.0.8 to 4.0.9 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/js-yaml) Updates `@types/semver` from 7.5.4 to 7.5.5 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/semver) Updates `@typescript-eslint/eslint-plugin` from 6.9.1 to 6.12.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.12.0/packages/eslint-plugin) Updates `@typescript-eslint/parser` from 6.9.1 to 6.12.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.12.0/packages/parser) Updates `eslint` from 8.52.0 to 8.54.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v8.52.0...v8.54.0) Updates `nock` from 13.3.7 to 13.3.8 - [Release notes](https://github.com/nock/nock/releases) - [Changelog](https://github.com/nock/nock/blob/main/CHANGELOG.md) - [Commits](https://github.com/nock/nock/compare/v13.3.7...v13.3.8) Updates `sinon` from 17.0.0 to 17.0.1 - [Release notes](https://github.com/sinonjs/sinon/releases) - [Changelog](https://github.com/sinonjs/sinon/blob/main/docs/changelog.md) - [Commits](https://github.com/sinonjs/sinon/compare/v17.0.0...v17.0.1) Updates `@types/sinon` from 10.0.20 to 17.0.1 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/sinon) Updates `typescript` from 5.2.2 to 5.3.2 - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](https://github.com/Microsoft/TypeScript/commits) --- updated-dependencies: - dependency-name: "@octokit/types" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: npm - dependency-name: "@types/uuid" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@types/adm-zip" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@types/js-yaml" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@types/semver" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm - dependency-name: nock dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: sinon dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@types/sinon" dependency-type: direct:development update-type: version-update:semver-major dependency-group: npm - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm ... Signed-off-by: dependabot[bot] <support@github.com> * Update checked-in dependencies * Rebuild --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
286 lines
10 KiB
JavaScript
286 lines
10 KiB
JavaScript
/**
|
|
* @fileoverview Disallows or enforces spaces inside of parentheses.
|
|
* @author Jonathan Rajavuori
|
|
* @deprecated in ESLint v8.53.0
|
|
*/
|
|
"use strict";
|
|
|
|
const astUtils = require("./utils/ast-utils");
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../shared/types').Rule} */
|
|
module.exports = {
|
|
meta: {
|
|
deprecated: true,
|
|
replacedBy: [],
|
|
type: "layout",
|
|
|
|
docs: {
|
|
description: "Enforce consistent spacing inside parentheses",
|
|
recommended: false,
|
|
url: "https://eslint.org/docs/latest/rules/space-in-parens"
|
|
},
|
|
|
|
fixable: "whitespace",
|
|
|
|
schema: [
|
|
{
|
|
enum: ["always", "never"]
|
|
},
|
|
{
|
|
type: "object",
|
|
properties: {
|
|
exceptions: {
|
|
type: "array",
|
|
items: {
|
|
enum: ["{}", "[]", "()", "empty"]
|
|
},
|
|
uniqueItems: true
|
|
}
|
|
},
|
|
additionalProperties: false
|
|
}
|
|
],
|
|
|
|
messages: {
|
|
missingOpeningSpace: "There must be a space after this paren.",
|
|
missingClosingSpace: "There must be a space before this paren.",
|
|
rejectedOpeningSpace: "There should be no space after this paren.",
|
|
rejectedClosingSpace: "There should be no space before this paren."
|
|
}
|
|
},
|
|
|
|
create(context) {
|
|
const ALWAYS = context.options[0] === "always",
|
|
exceptionsArrayOptions = (context.options[1] && context.options[1].exceptions) || [],
|
|
options = {};
|
|
|
|
let exceptions;
|
|
|
|
if (exceptionsArrayOptions.length) {
|
|
options.braceException = exceptionsArrayOptions.includes("{}");
|
|
options.bracketException = exceptionsArrayOptions.includes("[]");
|
|
options.parenException = exceptionsArrayOptions.includes("()");
|
|
options.empty = exceptionsArrayOptions.includes("empty");
|
|
}
|
|
|
|
/**
|
|
* Produces an object with the opener and closer exception values
|
|
* @returns {Object} `openers` and `closers` exception values
|
|
* @private
|
|
*/
|
|
function getExceptions() {
|
|
const openers = [],
|
|
closers = [];
|
|
|
|
if (options.braceException) {
|
|
openers.push("{");
|
|
closers.push("}");
|
|
}
|
|
|
|
if (options.bracketException) {
|
|
openers.push("[");
|
|
closers.push("]");
|
|
}
|
|
|
|
if (options.parenException) {
|
|
openers.push("(");
|
|
closers.push(")");
|
|
}
|
|
|
|
if (options.empty) {
|
|
openers.push(")");
|
|
closers.push("(");
|
|
}
|
|
|
|
return {
|
|
openers,
|
|
closers
|
|
};
|
|
}
|
|
|
|
//--------------------------------------------------------------------------
|
|
// Helpers
|
|
//--------------------------------------------------------------------------
|
|
const sourceCode = context.sourceCode;
|
|
|
|
/**
|
|
* Determines if a token is one of the exceptions for the opener paren
|
|
* @param {Object} token The token to check
|
|
* @returns {boolean} True if the token is one of the exceptions for the opener paren
|
|
*/
|
|
function isOpenerException(token) {
|
|
return exceptions.openers.includes(token.value);
|
|
}
|
|
|
|
/**
|
|
* Determines if a token is one of the exceptions for the closer paren
|
|
* @param {Object} token The token to check
|
|
* @returns {boolean} True if the token is one of the exceptions for the closer paren
|
|
*/
|
|
function isCloserException(token) {
|
|
return exceptions.closers.includes(token.value);
|
|
}
|
|
|
|
/**
|
|
* Determines if an opening paren is immediately followed by a required space
|
|
* @param {Object} openingParenToken The paren token
|
|
* @param {Object} tokenAfterOpeningParen The token after it
|
|
* @returns {boolean} True if the opening paren is missing a required space
|
|
*/
|
|
function openerMissingSpace(openingParenToken, tokenAfterOpeningParen) {
|
|
if (sourceCode.isSpaceBetweenTokens(openingParenToken, tokenAfterOpeningParen)) {
|
|
return false;
|
|
}
|
|
|
|
if (!options.empty && astUtils.isClosingParenToken(tokenAfterOpeningParen)) {
|
|
return false;
|
|
}
|
|
|
|
if (ALWAYS) {
|
|
return !isOpenerException(tokenAfterOpeningParen);
|
|
}
|
|
return isOpenerException(tokenAfterOpeningParen);
|
|
}
|
|
|
|
/**
|
|
* Determines if an opening paren is immediately followed by a disallowed space
|
|
* @param {Object} openingParenToken The paren token
|
|
* @param {Object} tokenAfterOpeningParen The token after it
|
|
* @returns {boolean} True if the opening paren has a disallowed space
|
|
*/
|
|
function openerRejectsSpace(openingParenToken, tokenAfterOpeningParen) {
|
|
if (!astUtils.isTokenOnSameLine(openingParenToken, tokenAfterOpeningParen)) {
|
|
return false;
|
|
}
|
|
|
|
if (tokenAfterOpeningParen.type === "Line") {
|
|
return false;
|
|
}
|
|
|
|
if (!sourceCode.isSpaceBetweenTokens(openingParenToken, tokenAfterOpeningParen)) {
|
|
return false;
|
|
}
|
|
|
|
if (ALWAYS) {
|
|
return isOpenerException(tokenAfterOpeningParen);
|
|
}
|
|
return !isOpenerException(tokenAfterOpeningParen);
|
|
}
|
|
|
|
/**
|
|
* Determines if a closing paren is immediately preceded by a required space
|
|
* @param {Object} tokenBeforeClosingParen The token before the paren
|
|
* @param {Object} closingParenToken The paren token
|
|
* @returns {boolean} True if the closing paren is missing a required space
|
|
*/
|
|
function closerMissingSpace(tokenBeforeClosingParen, closingParenToken) {
|
|
if (sourceCode.isSpaceBetweenTokens(tokenBeforeClosingParen, closingParenToken)) {
|
|
return false;
|
|
}
|
|
|
|
if (!options.empty && astUtils.isOpeningParenToken(tokenBeforeClosingParen)) {
|
|
return false;
|
|
}
|
|
|
|
if (ALWAYS) {
|
|
return !isCloserException(tokenBeforeClosingParen);
|
|
}
|
|
return isCloserException(tokenBeforeClosingParen);
|
|
}
|
|
|
|
/**
|
|
* Determines if a closer paren is immediately preceded by a disallowed space
|
|
* @param {Object} tokenBeforeClosingParen The token before the paren
|
|
* @param {Object} closingParenToken The paren token
|
|
* @returns {boolean} True if the closing paren has a disallowed space
|
|
*/
|
|
function closerRejectsSpace(tokenBeforeClosingParen, closingParenToken) {
|
|
if (!astUtils.isTokenOnSameLine(tokenBeforeClosingParen, closingParenToken)) {
|
|
return false;
|
|
}
|
|
|
|
if (!sourceCode.isSpaceBetweenTokens(tokenBeforeClosingParen, closingParenToken)) {
|
|
return false;
|
|
}
|
|
|
|
if (ALWAYS) {
|
|
return isCloserException(tokenBeforeClosingParen);
|
|
}
|
|
return !isCloserException(tokenBeforeClosingParen);
|
|
}
|
|
|
|
//--------------------------------------------------------------------------
|
|
// Public
|
|
//--------------------------------------------------------------------------
|
|
|
|
return {
|
|
Program: function checkParenSpaces(node) {
|
|
exceptions = getExceptions();
|
|
const tokens = sourceCode.tokensAndComments;
|
|
|
|
tokens.forEach((token, i) => {
|
|
const prevToken = tokens[i - 1];
|
|
const nextToken = tokens[i + 1];
|
|
|
|
// if token is not an opening or closing paren token, do nothing
|
|
if (!astUtils.isOpeningParenToken(token) && !astUtils.isClosingParenToken(token)) {
|
|
return;
|
|
}
|
|
|
|
// if token is an opening paren and is not followed by a required space
|
|
if (token.value === "(" && openerMissingSpace(token, nextToken)) {
|
|
context.report({
|
|
node,
|
|
loc: token.loc,
|
|
messageId: "missingOpeningSpace",
|
|
fix(fixer) {
|
|
return fixer.insertTextAfter(token, " ");
|
|
}
|
|
});
|
|
}
|
|
|
|
// if token is an opening paren and is followed by a disallowed space
|
|
if (token.value === "(" && openerRejectsSpace(token, nextToken)) {
|
|
context.report({
|
|
node,
|
|
loc: { start: token.loc.end, end: nextToken.loc.start },
|
|
messageId: "rejectedOpeningSpace",
|
|
fix(fixer) {
|
|
return fixer.removeRange([token.range[1], nextToken.range[0]]);
|
|
}
|
|
});
|
|
}
|
|
|
|
// if token is a closing paren and is not preceded by a required space
|
|
if (token.value === ")" && closerMissingSpace(prevToken, token)) {
|
|
context.report({
|
|
node,
|
|
loc: token.loc,
|
|
messageId: "missingClosingSpace",
|
|
fix(fixer) {
|
|
return fixer.insertTextBefore(token, " ");
|
|
}
|
|
});
|
|
}
|
|
|
|
// if token is a closing paren and is preceded by a disallowed space
|
|
if (token.value === ")" && closerRejectsSpace(prevToken, token)) {
|
|
context.report({
|
|
node,
|
|
loc: { start: prevToken.loc.end, end: token.loc.start },
|
|
messageId: "rejectedClosingSpace",
|
|
fix(fixer) {
|
|
return fixer.removeRange([prevToken.range[1], token.range[0]]);
|
|
}
|
|
});
|
|
}
|
|
});
|
|
}
|
|
};
|
|
}
|
|
};
|