mirror of
https://github.com/github/codeql-action.git
synced 2026-01-03 21:20:09 +08:00
* Bump the npm group with 12 updates Bumps the npm group with 12 updates: | Package | From | To | | --- | --- | --- | | [@octokit/types](https://github.com/octokit/types.ts) | `12.1.1` | `12.3.0` | | [@types/uuid](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/uuid) | `9.0.6` | `9.0.7` | | [@types/adm-zip](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/adm-zip) | `0.5.3` | `0.5.4` | | [@types/js-yaml](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/js-yaml) | `4.0.8` | `4.0.9` | | [@types/semver](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/semver) | `7.5.4` | `7.5.5` | | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) | `6.9.1` | `6.12.0` | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) | `6.9.1` | `6.12.0` | | [eslint](https://github.com/eslint/eslint) | `8.52.0` | `8.54.0` | | [nock](https://github.com/nock/nock) | `13.3.7` | `13.3.8` | | [sinon](https://github.com/sinonjs/sinon) | `17.0.0` | `17.0.1` | | [@types/sinon](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/sinon) | `10.0.20` | `17.0.1` | | [typescript](https://github.com/Microsoft/TypeScript) | `5.2.2` | `5.3.2` | Updates `@octokit/types` from 12.1.1 to 12.3.0 - [Release notes](https://github.com/octokit/types.ts/releases) - [Commits](https://github.com/octokit/types.ts/compare/v12.1.1...v12.3.0) Updates `@types/uuid` from 9.0.6 to 9.0.7 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/uuid) Updates `@types/adm-zip` from 0.5.3 to 0.5.4 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/adm-zip) Updates `@types/js-yaml` from 4.0.8 to 4.0.9 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/js-yaml) Updates `@types/semver` from 7.5.4 to 7.5.5 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/semver) Updates `@typescript-eslint/eslint-plugin` from 6.9.1 to 6.12.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.12.0/packages/eslint-plugin) Updates `@typescript-eslint/parser` from 6.9.1 to 6.12.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.12.0/packages/parser) Updates `eslint` from 8.52.0 to 8.54.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v8.52.0...v8.54.0) Updates `nock` from 13.3.7 to 13.3.8 - [Release notes](https://github.com/nock/nock/releases) - [Changelog](https://github.com/nock/nock/blob/main/CHANGELOG.md) - [Commits](https://github.com/nock/nock/compare/v13.3.7...v13.3.8) Updates `sinon` from 17.0.0 to 17.0.1 - [Release notes](https://github.com/sinonjs/sinon/releases) - [Changelog](https://github.com/sinonjs/sinon/blob/main/docs/changelog.md) - [Commits](https://github.com/sinonjs/sinon/compare/v17.0.0...v17.0.1) Updates `@types/sinon` from 10.0.20 to 17.0.1 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/sinon) Updates `typescript` from 5.2.2 to 5.3.2 - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](https://github.com/Microsoft/TypeScript/commits) --- updated-dependencies: - dependency-name: "@octokit/types" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: npm - dependency-name: "@types/uuid" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@types/adm-zip" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@types/js-yaml" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@types/semver" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm - dependency-name: nock dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: sinon dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@types/sinon" dependency-type: direct:development update-type: version-update:semver-major dependency-group: npm - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm ... Signed-off-by: dependabot[bot] <support@github.com> * Update checked-in dependencies * Rebuild --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
325 lines
12 KiB
JavaScript
325 lines
12 KiB
JavaScript
/**
|
|
* @fileoverview This rule should require or disallow spaces before or after unary operations.
|
|
* @author Marcin Kumorek
|
|
* @deprecated in ESLint v8.53.0
|
|
*/
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Requirements
|
|
//------------------------------------------------------------------------------
|
|
|
|
const astUtils = require("./utils/ast-utils");
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../shared/types').Rule} */
|
|
module.exports = {
|
|
meta: {
|
|
deprecated: true,
|
|
replacedBy: [],
|
|
type: "layout",
|
|
|
|
docs: {
|
|
description: "Enforce consistent spacing before or after unary operators",
|
|
recommended: false,
|
|
url: "https://eslint.org/docs/latest/rules/space-unary-ops"
|
|
},
|
|
|
|
fixable: "whitespace",
|
|
|
|
schema: [
|
|
{
|
|
type: "object",
|
|
properties: {
|
|
words: {
|
|
type: "boolean",
|
|
default: true
|
|
},
|
|
nonwords: {
|
|
type: "boolean",
|
|
default: false
|
|
},
|
|
overrides: {
|
|
type: "object",
|
|
additionalProperties: {
|
|
type: "boolean"
|
|
}
|
|
}
|
|
},
|
|
additionalProperties: false
|
|
}
|
|
],
|
|
messages: {
|
|
unexpectedBefore: "Unexpected space before unary operator '{{operator}}'.",
|
|
unexpectedAfter: "Unexpected space after unary operator '{{operator}}'.",
|
|
unexpectedAfterWord: "Unexpected space after unary word operator '{{word}}'.",
|
|
wordOperator: "Unary word operator '{{word}}' must be followed by whitespace.",
|
|
operator: "Unary operator '{{operator}}' must be followed by whitespace.",
|
|
beforeUnaryExpressions: "Space is required before unary expressions '{{token}}'."
|
|
}
|
|
},
|
|
|
|
create(context) {
|
|
const options = context.options[0] || { words: true, nonwords: false };
|
|
|
|
const sourceCode = context.sourceCode;
|
|
|
|
//--------------------------------------------------------------------------
|
|
// Helpers
|
|
//--------------------------------------------------------------------------
|
|
|
|
/**
|
|
* Check if the node is the first "!" in a "!!" convert to Boolean expression
|
|
* @param {ASTnode} node AST node
|
|
* @returns {boolean} Whether or not the node is first "!" in "!!"
|
|
*/
|
|
function isFirstBangInBangBangExpression(node) {
|
|
return node && node.type === "UnaryExpression" && node.argument.operator === "!" &&
|
|
node.argument && node.argument.type === "UnaryExpression" && node.argument.operator === "!";
|
|
}
|
|
|
|
/**
|
|
* Checks if an override exists for a given operator.
|
|
* @param {string} operator Operator
|
|
* @returns {boolean} Whether or not an override has been provided for the operator
|
|
*/
|
|
function overrideExistsForOperator(operator) {
|
|
return options.overrides && Object.prototype.hasOwnProperty.call(options.overrides, operator);
|
|
}
|
|
|
|
/**
|
|
* Gets the value that the override was set to for this operator
|
|
* @param {string} operator Operator
|
|
* @returns {boolean} Whether or not an override enforces a space with this operator
|
|
*/
|
|
function overrideEnforcesSpaces(operator) {
|
|
return options.overrides[operator];
|
|
}
|
|
|
|
/**
|
|
* Verify Unary Word Operator has spaces after the word operator
|
|
* @param {ASTnode} node AST node
|
|
* @param {Object} firstToken first token from the AST node
|
|
* @param {Object} secondToken second token from the AST node
|
|
* @param {string} word The word to be used for reporting
|
|
* @returns {void}
|
|
*/
|
|
function verifyWordHasSpaces(node, firstToken, secondToken, word) {
|
|
if (secondToken.range[0] === firstToken.range[1]) {
|
|
context.report({
|
|
node,
|
|
messageId: "wordOperator",
|
|
data: {
|
|
word
|
|
},
|
|
fix(fixer) {
|
|
return fixer.insertTextAfter(firstToken, " ");
|
|
}
|
|
});
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Verify Unary Word Operator doesn't have spaces after the word operator
|
|
* @param {ASTnode} node AST node
|
|
* @param {Object} firstToken first token from the AST node
|
|
* @param {Object} secondToken second token from the AST node
|
|
* @param {string} word The word to be used for reporting
|
|
* @returns {void}
|
|
*/
|
|
function verifyWordDoesntHaveSpaces(node, firstToken, secondToken, word) {
|
|
if (astUtils.canTokensBeAdjacent(firstToken, secondToken)) {
|
|
if (secondToken.range[0] > firstToken.range[1]) {
|
|
context.report({
|
|
node,
|
|
messageId: "unexpectedAfterWord",
|
|
data: {
|
|
word
|
|
},
|
|
fix(fixer) {
|
|
return fixer.removeRange([firstToken.range[1], secondToken.range[0]]);
|
|
}
|
|
});
|
|
}
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Check Unary Word Operators for spaces after the word operator
|
|
* @param {ASTnode} node AST node
|
|
* @param {Object} firstToken first token from the AST node
|
|
* @param {Object} secondToken second token from the AST node
|
|
* @param {string} word The word to be used for reporting
|
|
* @returns {void}
|
|
*/
|
|
function checkUnaryWordOperatorForSpaces(node, firstToken, secondToken, word) {
|
|
if (overrideExistsForOperator(word)) {
|
|
if (overrideEnforcesSpaces(word)) {
|
|
verifyWordHasSpaces(node, firstToken, secondToken, word);
|
|
} else {
|
|
verifyWordDoesntHaveSpaces(node, firstToken, secondToken, word);
|
|
}
|
|
} else if (options.words) {
|
|
verifyWordHasSpaces(node, firstToken, secondToken, word);
|
|
} else {
|
|
verifyWordDoesntHaveSpaces(node, firstToken, secondToken, word);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Verifies YieldExpressions satisfy spacing requirements
|
|
* @param {ASTnode} node AST node
|
|
* @returns {void}
|
|
*/
|
|
function checkForSpacesAfterYield(node) {
|
|
const tokens = sourceCode.getFirstTokens(node, 3),
|
|
word = "yield";
|
|
|
|
if (!node.argument || node.delegate) {
|
|
return;
|
|
}
|
|
|
|
checkUnaryWordOperatorForSpaces(node, tokens[0], tokens[1], word);
|
|
}
|
|
|
|
/**
|
|
* Verifies AwaitExpressions satisfy spacing requirements
|
|
* @param {ASTNode} node AwaitExpression AST node
|
|
* @returns {void}
|
|
*/
|
|
function checkForSpacesAfterAwait(node) {
|
|
const tokens = sourceCode.getFirstTokens(node, 3);
|
|
|
|
checkUnaryWordOperatorForSpaces(node, tokens[0], tokens[1], "await");
|
|
}
|
|
|
|
/**
|
|
* Verifies UnaryExpression, UpdateExpression and NewExpression have spaces before or after the operator
|
|
* @param {ASTnode} node AST node
|
|
* @param {Object} firstToken First token in the expression
|
|
* @param {Object} secondToken Second token in the expression
|
|
* @returns {void}
|
|
*/
|
|
function verifyNonWordsHaveSpaces(node, firstToken, secondToken) {
|
|
if (node.prefix) {
|
|
if (isFirstBangInBangBangExpression(node)) {
|
|
return;
|
|
}
|
|
if (firstToken.range[1] === secondToken.range[0]) {
|
|
context.report({
|
|
node,
|
|
messageId: "operator",
|
|
data: {
|
|
operator: firstToken.value
|
|
},
|
|
fix(fixer) {
|
|
return fixer.insertTextAfter(firstToken, " ");
|
|
}
|
|
});
|
|
}
|
|
} else {
|
|
if (firstToken.range[1] === secondToken.range[0]) {
|
|
context.report({
|
|
node,
|
|
messageId: "beforeUnaryExpressions",
|
|
data: {
|
|
token: secondToken.value
|
|
},
|
|
fix(fixer) {
|
|
return fixer.insertTextBefore(secondToken, " ");
|
|
}
|
|
});
|
|
}
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Verifies UnaryExpression, UpdateExpression and NewExpression don't have spaces before or after the operator
|
|
* @param {ASTnode} node AST node
|
|
* @param {Object} firstToken First token in the expression
|
|
* @param {Object} secondToken Second token in the expression
|
|
* @returns {void}
|
|
*/
|
|
function verifyNonWordsDontHaveSpaces(node, firstToken, secondToken) {
|
|
if (node.prefix) {
|
|
if (secondToken.range[0] > firstToken.range[1]) {
|
|
context.report({
|
|
node,
|
|
messageId: "unexpectedAfter",
|
|
data: {
|
|
operator: firstToken.value
|
|
},
|
|
fix(fixer) {
|
|
if (astUtils.canTokensBeAdjacent(firstToken, secondToken)) {
|
|
return fixer.removeRange([firstToken.range[1], secondToken.range[0]]);
|
|
}
|
|
return null;
|
|
}
|
|
});
|
|
}
|
|
} else {
|
|
if (secondToken.range[0] > firstToken.range[1]) {
|
|
context.report({
|
|
node,
|
|
messageId: "unexpectedBefore",
|
|
data: {
|
|
operator: secondToken.value
|
|
},
|
|
fix(fixer) {
|
|
return fixer.removeRange([firstToken.range[1], secondToken.range[0]]);
|
|
}
|
|
});
|
|
}
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Verifies UnaryExpression, UpdateExpression and NewExpression satisfy spacing requirements
|
|
* @param {ASTnode} node AST node
|
|
* @returns {void}
|
|
*/
|
|
function checkForSpaces(node) {
|
|
const tokens = node.type === "UpdateExpression" && !node.prefix
|
|
? sourceCode.getLastTokens(node, 2)
|
|
: sourceCode.getFirstTokens(node, 2);
|
|
const firstToken = tokens[0];
|
|
const secondToken = tokens[1];
|
|
|
|
if ((node.type === "NewExpression" || node.prefix) && firstToken.type === "Keyword") {
|
|
checkUnaryWordOperatorForSpaces(node, firstToken, secondToken, firstToken.value);
|
|
return;
|
|
}
|
|
|
|
const operator = node.prefix ? tokens[0].value : tokens[1].value;
|
|
|
|
if (overrideExistsForOperator(operator)) {
|
|
if (overrideEnforcesSpaces(operator)) {
|
|
verifyNonWordsHaveSpaces(node, firstToken, secondToken);
|
|
} else {
|
|
verifyNonWordsDontHaveSpaces(node, firstToken, secondToken);
|
|
}
|
|
} else if (options.nonwords) {
|
|
verifyNonWordsHaveSpaces(node, firstToken, secondToken);
|
|
} else {
|
|
verifyNonWordsDontHaveSpaces(node, firstToken, secondToken);
|
|
}
|
|
}
|
|
|
|
//--------------------------------------------------------------------------
|
|
// Public
|
|
//--------------------------------------------------------------------------
|
|
|
|
return {
|
|
UnaryExpression: checkForSpaces,
|
|
UpdateExpression: checkForSpaces,
|
|
NewExpression: checkForSpaces,
|
|
YieldExpression: checkForSpacesAfterYield,
|
|
AwaitExpression: checkForSpacesAfterAwait
|
|
};
|
|
|
|
}
|
|
};
|