mirror of
https://github.com/github/codeql-action.git
synced 2025-12-31 03:30:14 +08:00
* Bump the npm group with 12 updates Bumps the npm group with 12 updates: | Package | From | To | | --- | --- | --- | | [@octokit/types](https://github.com/octokit/types.ts) | `12.1.1` | `12.3.0` | | [@types/uuid](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/uuid) | `9.0.6` | `9.0.7` | | [@types/adm-zip](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/adm-zip) | `0.5.3` | `0.5.4` | | [@types/js-yaml](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/js-yaml) | `4.0.8` | `4.0.9` | | [@types/semver](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/semver) | `7.5.4` | `7.5.5` | | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) | `6.9.1` | `6.12.0` | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) | `6.9.1` | `6.12.0` | | [eslint](https://github.com/eslint/eslint) | `8.52.0` | `8.54.0` | | [nock](https://github.com/nock/nock) | `13.3.7` | `13.3.8` | | [sinon](https://github.com/sinonjs/sinon) | `17.0.0` | `17.0.1` | | [@types/sinon](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/sinon) | `10.0.20` | `17.0.1` | | [typescript](https://github.com/Microsoft/TypeScript) | `5.2.2` | `5.3.2` | Updates `@octokit/types` from 12.1.1 to 12.3.0 - [Release notes](https://github.com/octokit/types.ts/releases) - [Commits](https://github.com/octokit/types.ts/compare/v12.1.1...v12.3.0) Updates `@types/uuid` from 9.0.6 to 9.0.7 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/uuid) Updates `@types/adm-zip` from 0.5.3 to 0.5.4 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/adm-zip) Updates `@types/js-yaml` from 4.0.8 to 4.0.9 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/js-yaml) Updates `@types/semver` from 7.5.4 to 7.5.5 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/semver) Updates `@typescript-eslint/eslint-plugin` from 6.9.1 to 6.12.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.12.0/packages/eslint-plugin) Updates `@typescript-eslint/parser` from 6.9.1 to 6.12.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.12.0/packages/parser) Updates `eslint` from 8.52.0 to 8.54.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v8.52.0...v8.54.0) Updates `nock` from 13.3.7 to 13.3.8 - [Release notes](https://github.com/nock/nock/releases) - [Changelog](https://github.com/nock/nock/blob/main/CHANGELOG.md) - [Commits](https://github.com/nock/nock/compare/v13.3.7...v13.3.8) Updates `sinon` from 17.0.0 to 17.0.1 - [Release notes](https://github.com/sinonjs/sinon/releases) - [Changelog](https://github.com/sinonjs/sinon/blob/main/docs/changelog.md) - [Commits](https://github.com/sinonjs/sinon/compare/v17.0.0...v17.0.1) Updates `@types/sinon` from 10.0.20 to 17.0.1 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/sinon) Updates `typescript` from 5.2.2 to 5.3.2 - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](https://github.com/Microsoft/TypeScript/commits) --- updated-dependencies: - dependency-name: "@octokit/types" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: npm - dependency-name: "@types/uuid" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@types/adm-zip" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@types/js-yaml" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@types/semver" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm - dependency-name: nock dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: sinon dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@types/sinon" dependency-type: direct:development update-type: version-update:semver-major dependency-group: npm - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm ... Signed-off-by: dependabot[bot] <support@github.com> * Update checked-in dependencies * Rebuild --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
193 lines
6.9 KiB
JavaScript
193 lines
6.9 KiB
JavaScript
/**
|
|
* @fileoverview Comma spacing - validates spacing before and after comma
|
|
* @author Vignesh Anand aka vegetableman.
|
|
* @deprecated in ESLint v8.53.0
|
|
*/
|
|
"use strict";
|
|
|
|
const astUtils = require("./utils/ast-utils");
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../shared/types').Rule} */
|
|
module.exports = {
|
|
meta: {
|
|
deprecated: true,
|
|
replacedBy: [],
|
|
type: "layout",
|
|
|
|
docs: {
|
|
description: "Enforce consistent spacing before and after commas",
|
|
recommended: false,
|
|
url: "https://eslint.org/docs/latest/rules/comma-spacing"
|
|
},
|
|
|
|
fixable: "whitespace",
|
|
|
|
schema: [
|
|
{
|
|
type: "object",
|
|
properties: {
|
|
before: {
|
|
type: "boolean",
|
|
default: false
|
|
},
|
|
after: {
|
|
type: "boolean",
|
|
default: true
|
|
}
|
|
},
|
|
additionalProperties: false
|
|
}
|
|
],
|
|
|
|
messages: {
|
|
missing: "A space is required {{loc}} ','.",
|
|
unexpected: "There should be no space {{loc}} ','."
|
|
}
|
|
},
|
|
|
|
create(context) {
|
|
|
|
const sourceCode = context.sourceCode;
|
|
const tokensAndComments = sourceCode.tokensAndComments;
|
|
|
|
const options = {
|
|
before: context.options[0] ? context.options[0].before : false,
|
|
after: context.options[0] ? context.options[0].after : true
|
|
};
|
|
|
|
//--------------------------------------------------------------------------
|
|
// Helpers
|
|
//--------------------------------------------------------------------------
|
|
|
|
// list of comma tokens to ignore for the check of leading whitespace
|
|
const commaTokensToIgnore = [];
|
|
|
|
/**
|
|
* Reports a spacing error with an appropriate message.
|
|
* @param {ASTNode} node The binary expression node to report.
|
|
* @param {string} loc Is the error "before" or "after" the comma?
|
|
* @param {ASTNode} otherNode The node at the left or right of `node`
|
|
* @returns {void}
|
|
* @private
|
|
*/
|
|
function report(node, loc, otherNode) {
|
|
context.report({
|
|
node,
|
|
fix(fixer) {
|
|
if (options[loc]) {
|
|
if (loc === "before") {
|
|
return fixer.insertTextBefore(node, " ");
|
|
}
|
|
return fixer.insertTextAfter(node, " ");
|
|
|
|
}
|
|
let start, end;
|
|
const newText = "";
|
|
|
|
if (loc === "before") {
|
|
start = otherNode.range[1];
|
|
end = node.range[0];
|
|
} else {
|
|
start = node.range[1];
|
|
end = otherNode.range[0];
|
|
}
|
|
|
|
return fixer.replaceTextRange([start, end], newText);
|
|
|
|
},
|
|
messageId: options[loc] ? "missing" : "unexpected",
|
|
data: {
|
|
loc
|
|
}
|
|
});
|
|
}
|
|
|
|
/**
|
|
* Adds null elements of the given ArrayExpression or ArrayPattern node to the ignore list.
|
|
* @param {ASTNode} node An ArrayExpression or ArrayPattern node.
|
|
* @returns {void}
|
|
*/
|
|
function addNullElementsToIgnoreList(node) {
|
|
let previousToken = sourceCode.getFirstToken(node);
|
|
|
|
node.elements.forEach(element => {
|
|
let token;
|
|
|
|
if (element === null) {
|
|
token = sourceCode.getTokenAfter(previousToken);
|
|
|
|
if (astUtils.isCommaToken(token)) {
|
|
commaTokensToIgnore.push(token);
|
|
}
|
|
} else {
|
|
token = sourceCode.getTokenAfter(element);
|
|
}
|
|
|
|
previousToken = token;
|
|
});
|
|
}
|
|
|
|
//--------------------------------------------------------------------------
|
|
// Public
|
|
//--------------------------------------------------------------------------
|
|
|
|
return {
|
|
"Program:exit"() {
|
|
tokensAndComments.forEach((token, i) => {
|
|
|
|
if (!astUtils.isCommaToken(token)) {
|
|
return;
|
|
}
|
|
|
|
const previousToken = tokensAndComments[i - 1];
|
|
const nextToken = tokensAndComments[i + 1];
|
|
|
|
if (
|
|
previousToken &&
|
|
!astUtils.isCommaToken(previousToken) && // ignore spacing between two commas
|
|
|
|
/*
|
|
* `commaTokensToIgnore` are ending commas of `null` elements (array holes/elisions).
|
|
* In addition to spacing between two commas, this can also ignore:
|
|
*
|
|
* - Spacing after `[` (controlled by array-bracket-spacing)
|
|
* Example: [ , ]
|
|
* ^
|
|
* - Spacing after a comment (for backwards compatibility, this was possibly unintentional)
|
|
* Example: [a, /* * / ,]
|
|
* ^
|
|
*/
|
|
!commaTokensToIgnore.includes(token) &&
|
|
|
|
astUtils.isTokenOnSameLine(previousToken, token) &&
|
|
options.before !== sourceCode.isSpaceBetweenTokens(previousToken, token)
|
|
) {
|
|
report(token, "before", previousToken);
|
|
}
|
|
|
|
if (
|
|
nextToken &&
|
|
!astUtils.isCommaToken(nextToken) && // ignore spacing between two commas
|
|
!astUtils.isClosingParenToken(nextToken) && // controlled by space-in-parens
|
|
!astUtils.isClosingBracketToken(nextToken) && // controlled by array-bracket-spacing
|
|
!astUtils.isClosingBraceToken(nextToken) && // controlled by object-curly-spacing
|
|
!(!options.after && nextToken.type === "Line") && // special case, allow space before line comment
|
|
astUtils.isTokenOnSameLine(token, nextToken) &&
|
|
options.after !== sourceCode.isSpaceBetweenTokens(token, nextToken)
|
|
) {
|
|
report(token, "after", nextToken);
|
|
}
|
|
});
|
|
},
|
|
ArrayExpression: addNullElementsToIgnoreList,
|
|
ArrayPattern: addNullElementsToIgnoreList
|
|
|
|
};
|
|
|
|
}
|
|
};
|