mirror of
https://github.com/github/codeql-action.git
synced 2025-12-27 17:50:07 +08:00
* Bump the npm group with 12 updates Bumps the npm group with 12 updates: | Package | From | To | | --- | --- | --- | | [@octokit/types](https://github.com/octokit/types.ts) | `12.1.1` | `12.3.0` | | [@types/uuid](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/uuid) | `9.0.6` | `9.0.7` | | [@types/adm-zip](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/adm-zip) | `0.5.3` | `0.5.4` | | [@types/js-yaml](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/js-yaml) | `4.0.8` | `4.0.9` | | [@types/semver](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/semver) | `7.5.4` | `7.5.5` | | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) | `6.9.1` | `6.12.0` | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) | `6.9.1` | `6.12.0` | | [eslint](https://github.com/eslint/eslint) | `8.52.0` | `8.54.0` | | [nock](https://github.com/nock/nock) | `13.3.7` | `13.3.8` | | [sinon](https://github.com/sinonjs/sinon) | `17.0.0` | `17.0.1` | | [@types/sinon](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/sinon) | `10.0.20` | `17.0.1` | | [typescript](https://github.com/Microsoft/TypeScript) | `5.2.2` | `5.3.2` | Updates `@octokit/types` from 12.1.1 to 12.3.0 - [Release notes](https://github.com/octokit/types.ts/releases) - [Commits](https://github.com/octokit/types.ts/compare/v12.1.1...v12.3.0) Updates `@types/uuid` from 9.0.6 to 9.0.7 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/uuid) Updates `@types/adm-zip` from 0.5.3 to 0.5.4 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/adm-zip) Updates `@types/js-yaml` from 4.0.8 to 4.0.9 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/js-yaml) Updates `@types/semver` from 7.5.4 to 7.5.5 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/semver) Updates `@typescript-eslint/eslint-plugin` from 6.9.1 to 6.12.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.12.0/packages/eslint-plugin) Updates `@typescript-eslint/parser` from 6.9.1 to 6.12.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.12.0/packages/parser) Updates `eslint` from 8.52.0 to 8.54.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v8.52.0...v8.54.0) Updates `nock` from 13.3.7 to 13.3.8 - [Release notes](https://github.com/nock/nock/releases) - [Changelog](https://github.com/nock/nock/blob/main/CHANGELOG.md) - [Commits](https://github.com/nock/nock/compare/v13.3.7...v13.3.8) Updates `sinon` from 17.0.0 to 17.0.1 - [Release notes](https://github.com/sinonjs/sinon/releases) - [Changelog](https://github.com/sinonjs/sinon/blob/main/docs/changelog.md) - [Commits](https://github.com/sinonjs/sinon/compare/v17.0.0...v17.0.1) Updates `@types/sinon` from 10.0.20 to 17.0.1 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/sinon) Updates `typescript` from 5.2.2 to 5.3.2 - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](https://github.com/Microsoft/TypeScript/commits) --- updated-dependencies: - dependency-name: "@octokit/types" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: npm - dependency-name: "@types/uuid" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@types/adm-zip" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@types/js-yaml" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@types/semver" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm - dependency-name: nock dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: sinon dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@types/sinon" dependency-type: direct:development update-type: version-update:semver-major dependency-group: npm - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm ... Signed-off-by: dependabot[bot] <support@github.com> * Update checked-in dependencies * Rebuild --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
312 lines
11 KiB
JavaScript
312 lines
11 KiB
JavaScript
/**
|
|
* @fileoverview Rule to enforce line breaks after each array element
|
|
* @author Jan Peer Stöcklmair <https://github.com/JPeer264>
|
|
* @deprecated in ESLint v8.53.0
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
const astUtils = require("./utils/ast-utils");
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../shared/types').Rule} */
|
|
module.exports = {
|
|
meta: {
|
|
deprecated: true,
|
|
replacedBy: [],
|
|
type: "layout",
|
|
|
|
docs: {
|
|
description: "Enforce line breaks after each array element",
|
|
recommended: false,
|
|
url: "https://eslint.org/docs/latest/rules/array-element-newline"
|
|
},
|
|
|
|
fixable: "whitespace",
|
|
|
|
schema: {
|
|
definitions: {
|
|
basicConfig: {
|
|
oneOf: [
|
|
{
|
|
enum: ["always", "never", "consistent"]
|
|
},
|
|
{
|
|
type: "object",
|
|
properties: {
|
|
multiline: {
|
|
type: "boolean"
|
|
},
|
|
minItems: {
|
|
type: ["integer", "null"],
|
|
minimum: 0
|
|
}
|
|
},
|
|
additionalProperties: false
|
|
}
|
|
]
|
|
}
|
|
},
|
|
type: "array",
|
|
items: [
|
|
{
|
|
oneOf: [
|
|
{
|
|
$ref: "#/definitions/basicConfig"
|
|
},
|
|
{
|
|
type: "object",
|
|
properties: {
|
|
ArrayExpression: {
|
|
$ref: "#/definitions/basicConfig"
|
|
},
|
|
ArrayPattern: {
|
|
$ref: "#/definitions/basicConfig"
|
|
}
|
|
},
|
|
additionalProperties: false,
|
|
minProperties: 1
|
|
}
|
|
]
|
|
}
|
|
]
|
|
},
|
|
|
|
messages: {
|
|
unexpectedLineBreak: "There should be no linebreak here.",
|
|
missingLineBreak: "There should be a linebreak after this element."
|
|
}
|
|
},
|
|
|
|
create(context) {
|
|
const sourceCode = context.sourceCode;
|
|
|
|
//----------------------------------------------------------------------
|
|
// Helpers
|
|
//----------------------------------------------------------------------
|
|
|
|
/**
|
|
* Normalizes a given option value.
|
|
* @param {string|Object|undefined} providedOption An option value to parse.
|
|
* @returns {{multiline: boolean, minItems: number}} Normalized option object.
|
|
*/
|
|
function normalizeOptionValue(providedOption) {
|
|
let consistent = false;
|
|
let multiline = false;
|
|
let minItems;
|
|
|
|
const option = providedOption || "always";
|
|
|
|
if (!option || option === "always" || option.minItems === 0) {
|
|
minItems = 0;
|
|
} else if (option === "never") {
|
|
minItems = Number.POSITIVE_INFINITY;
|
|
} else if (option === "consistent") {
|
|
consistent = true;
|
|
minItems = Number.POSITIVE_INFINITY;
|
|
} else {
|
|
multiline = Boolean(option.multiline);
|
|
minItems = option.minItems || Number.POSITIVE_INFINITY;
|
|
}
|
|
|
|
return { consistent, multiline, minItems };
|
|
}
|
|
|
|
/**
|
|
* Normalizes a given option value.
|
|
* @param {string|Object|undefined} options An option value to parse.
|
|
* @returns {{ArrayExpression: {multiline: boolean, minItems: number}, ArrayPattern: {multiline: boolean, minItems: number}}} Normalized option object.
|
|
*/
|
|
function normalizeOptions(options) {
|
|
if (options && (options.ArrayExpression || options.ArrayPattern)) {
|
|
let expressionOptions, patternOptions;
|
|
|
|
if (options.ArrayExpression) {
|
|
expressionOptions = normalizeOptionValue(options.ArrayExpression);
|
|
}
|
|
|
|
if (options.ArrayPattern) {
|
|
patternOptions = normalizeOptionValue(options.ArrayPattern);
|
|
}
|
|
|
|
return { ArrayExpression: expressionOptions, ArrayPattern: patternOptions };
|
|
}
|
|
|
|
const value = normalizeOptionValue(options);
|
|
|
|
return { ArrayExpression: value, ArrayPattern: value };
|
|
}
|
|
|
|
/**
|
|
* Reports that there shouldn't be a line break after the first token
|
|
* @param {Token} token The token to use for the report.
|
|
* @returns {void}
|
|
*/
|
|
function reportNoLineBreak(token) {
|
|
const tokenBefore = sourceCode.getTokenBefore(token, { includeComments: true });
|
|
|
|
context.report({
|
|
loc: {
|
|
start: tokenBefore.loc.end,
|
|
end: token.loc.start
|
|
},
|
|
messageId: "unexpectedLineBreak",
|
|
fix(fixer) {
|
|
if (astUtils.isCommentToken(tokenBefore)) {
|
|
return null;
|
|
}
|
|
|
|
if (!astUtils.isTokenOnSameLine(tokenBefore, token)) {
|
|
return fixer.replaceTextRange([tokenBefore.range[1], token.range[0]], " ");
|
|
}
|
|
|
|
/*
|
|
* This will check if the comma is on the same line as the next element
|
|
* Following array:
|
|
* [
|
|
* 1
|
|
* , 2
|
|
* , 3
|
|
* ]
|
|
*
|
|
* will be fixed to:
|
|
* [
|
|
* 1, 2, 3
|
|
* ]
|
|
*/
|
|
const twoTokensBefore = sourceCode.getTokenBefore(tokenBefore, { includeComments: true });
|
|
|
|
if (astUtils.isCommentToken(twoTokensBefore)) {
|
|
return null;
|
|
}
|
|
|
|
return fixer.replaceTextRange([twoTokensBefore.range[1], tokenBefore.range[0]], "");
|
|
|
|
}
|
|
});
|
|
}
|
|
|
|
/**
|
|
* Reports that there should be a line break after the first token
|
|
* @param {Token} token The token to use for the report.
|
|
* @returns {void}
|
|
*/
|
|
function reportRequiredLineBreak(token) {
|
|
const tokenBefore = sourceCode.getTokenBefore(token, { includeComments: true });
|
|
|
|
context.report({
|
|
loc: {
|
|
start: tokenBefore.loc.end,
|
|
end: token.loc.start
|
|
},
|
|
messageId: "missingLineBreak",
|
|
fix(fixer) {
|
|
return fixer.replaceTextRange([tokenBefore.range[1], token.range[0]], "\n");
|
|
}
|
|
});
|
|
}
|
|
|
|
/**
|
|
* Reports a given node if it violated this rule.
|
|
* @param {ASTNode} node A node to check. This is an ObjectExpression node or an ObjectPattern node.
|
|
* @returns {void}
|
|
*/
|
|
function check(node) {
|
|
const elements = node.elements;
|
|
const normalizedOptions = normalizeOptions(context.options[0]);
|
|
const options = normalizedOptions[node.type];
|
|
|
|
if (!options) {
|
|
return;
|
|
}
|
|
|
|
let elementBreak = false;
|
|
|
|
/*
|
|
* MULTILINE: true
|
|
* loop through every element and check
|
|
* if at least one element has linebreaks inside
|
|
* this ensures that following is not valid (due to elements are on the same line):
|
|
*
|
|
* [
|
|
* 1,
|
|
* 2,
|
|
* 3
|
|
* ]
|
|
*/
|
|
if (options.multiline) {
|
|
elementBreak = elements
|
|
.filter(element => element !== null)
|
|
.some(element => element.loc.start.line !== element.loc.end.line);
|
|
}
|
|
|
|
let linebreaksCount = 0;
|
|
|
|
for (let i = 0; i < node.elements.length; i++) {
|
|
const element = node.elements[i];
|
|
|
|
const previousElement = elements[i - 1];
|
|
|
|
if (i === 0 || element === null || previousElement === null) {
|
|
continue;
|
|
}
|
|
|
|
const commaToken = sourceCode.getFirstTokenBetween(previousElement, element, astUtils.isCommaToken);
|
|
const lastTokenOfPreviousElement = sourceCode.getTokenBefore(commaToken);
|
|
const firstTokenOfCurrentElement = sourceCode.getTokenAfter(commaToken);
|
|
|
|
if (!astUtils.isTokenOnSameLine(lastTokenOfPreviousElement, firstTokenOfCurrentElement)) {
|
|
linebreaksCount++;
|
|
}
|
|
}
|
|
|
|
const needsLinebreaks = (
|
|
elements.length >= options.minItems ||
|
|
(
|
|
options.multiline &&
|
|
elementBreak
|
|
) ||
|
|
(
|
|
options.consistent &&
|
|
linebreaksCount > 0 &&
|
|
linebreaksCount < node.elements.length
|
|
)
|
|
);
|
|
|
|
elements.forEach((element, i) => {
|
|
const previousElement = elements[i - 1];
|
|
|
|
if (i === 0 || element === null || previousElement === null) {
|
|
return;
|
|
}
|
|
|
|
const commaToken = sourceCode.getFirstTokenBetween(previousElement, element, astUtils.isCommaToken);
|
|
const lastTokenOfPreviousElement = sourceCode.getTokenBefore(commaToken);
|
|
const firstTokenOfCurrentElement = sourceCode.getTokenAfter(commaToken);
|
|
|
|
if (needsLinebreaks) {
|
|
if (astUtils.isTokenOnSameLine(lastTokenOfPreviousElement, firstTokenOfCurrentElement)) {
|
|
reportRequiredLineBreak(firstTokenOfCurrentElement);
|
|
}
|
|
} else {
|
|
if (!astUtils.isTokenOnSameLine(lastTokenOfPreviousElement, firstTokenOfCurrentElement)) {
|
|
reportNoLineBreak(firstTokenOfCurrentElement);
|
|
}
|
|
}
|
|
});
|
|
}
|
|
|
|
//----------------------------------------------------------------------
|
|
// Public
|
|
//----------------------------------------------------------------------
|
|
|
|
return {
|
|
ArrayPattern: check,
|
|
ArrayExpression: check
|
|
};
|
|
}
|
|
};
|